fix(inspector): stream patched state updates#4795
fix(inspector): stream patched state updates#4795NathanFlurry wants to merge 1 commit into04-24-replay/ts-client-stale-actor-retryfrom
Conversation
Code Review: fix(inspector): stream patched state updatesOverviewThis PR fixes a bug where PATCH
The two Rust changes are tightly coupled: re-enabling the signal (2) while still calling Code QualityRust changes are clean and correct. The comments in both files follow CLAUDE.md style (complete sentences, no dashes, lowercase unless referencing symbols), and the comment explaining the duplicate-avoidance rationale in Test helpers ( Specific Issues / SuggestionsMinor: If the WebSocket closes unexpectedly before the const onClose = (event: CloseEvent) => {
cleanup();
reject(new Error(`Inspector websocket closed before open: ${event.code} ${event.reason}`));
};
ws.addEventListener("close", onClose);
// and remove it in cleanup()Minor: Both Minor: Missing If the WebSocket closes mid-wait (actor dies, network drop), the promise silently hangs until timeout. Same pattern as above — a Note: CLAUDE.md states justification comments are required adjacent to Logic CorrectnessThe behavioral model is sound:
The test correctly validates both the WebSocket push ( Security / PerformanceNo concerns. Inspector signals are already scoped to authenticated WebSocket sessions. The removed overlay call is a minor throughput improvement (one fewer broadcast per save). SummaryThe fix is correct and well-motivated. The main actionable items are all in the test helpers (missing |
Preview packages published to npmInstall with: npm install rivetkit@pr-4795All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-e845d10
docker pull rivetdev/engine:full-e845d10Individual packagesnpm install rivetkit@pr-4795
npm install @rivetkit/react@pr-4795
npm install @rivetkit/rivetkit-napi@pr-4795
npm install @rivetkit/workflow-engine@pr-4795 |
f582eeb to
9634c9b
Compare
40c16f5 to
bede0d6
Compare
9634c9b to
0ad9786
Compare
bede0d6 to
ebe53f4
Compare
0ad9786 to
02bf749
Compare
02bf749 to
8bd50ce
Compare
ebe53f4 to
4f36573
Compare
4f36573 to
afdf798
Compare
8bd50ce to
ccd2fc4
Compare
afdf798 to
5903a99
Compare
1b393b1 to
77a93a5
Compare
5903a99 to
71e4b10
Compare
77a93a5 to
d5cb423
Compare
71e4b10 to
195b74b
Compare
d5cb423 to
bbd3d54
Compare
195b74b to
3e5a790
Compare
bbd3d54 to
f84be28
Compare
3e5a790 to
77dff4a
Compare
f84be28 to
f589b15
Compare
77dff4a to
00723b6
Compare
f589b15 to
dcb690f
Compare
00723b6 to
39879d7
Compare
|
Landed in main via stack-merge fast-forward push. Commits are in main; closing to match. |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: