test(rivetkit): cover c.db access from onWake/onSleep/onDestroy

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

• fix(pegboard): move sqlite v1 migration into actor workflow #4787 : 2 dependent PRs (#4797 , #4810 )
• test(rivetkit): cover c.db access from onWake/onSleep/onDestroy #4786 👈 (View in Graphite)
• fix(rivetkit-napi): run onMigrate before createState/onCreate/createVars #4785
• refactor(rivetkit-core): merge ready+started into lifecycle_started, drop redundant napi calls #4784
• fix(rivetkit): drain native sleep side tasks reliably #4782 : 1 other dependent PR (#4783 )
• fix(rivetkit): route raw request fetches to actors #4781
• fix(pegboard): refresh runner config after envoy connect #4778 : 2 other dependent PRs (#4779 , #4798 )
• chore(kitchen-sink): configurable endpoint #4766 : 2 other dependent PRs (#4754 , #4777 )
• refactor(rivetkit-core): rename StopReason to ShutdownKind and kill enum fallthroughs #4765
• chore(envoy-client): log command and event payloads #4751
• fix(rivetkit): minor sleep-cleanup follow-ups #4761
• docs(rivetkit): clean up stale setPreventSleep references in docs and JSDoc #4760
• docs(rivetkit): document keepAwake/waitUntil counter-arm race and surface bridge errors #4759
• test(engine): force overdue branch in alarm-during-sleep test with negative offset #4758
• fix(rivetkit-core): return stopping not starting when sleep/destroy called mid-shutdown #4757
• test(rivetkit): remove sleepWithPreventSleep fixture and tests #4756
• test(engine): add regression test for alarm-during-sleep-transition race #4755
• test(rivetkit-core): cover sleep/destroy guards and prevent_sleep no-op #4750
• docs: add keepAwake vs waitUntil table and internal sleep-sequence invariants #4749
• feat(rivetkit): expose c.keepAwake(promise) through native path #4748
• refactor(rivetkit): deprecate setPreventSleep to no-op in TypeScript #4747
• fix(rivetkit-core): enumerate non-drained counters in grace deadline warn log #4746
• fix(rivetkit-core): abort graceful cleanup task when grace deadline elapses #4745
• fix(rivetkit-core): error on sleep/destroy before startup or already-requested #4743
• fix(rivetkit-core): cap SerializeState shutdown timeout at 15s #4742
• refactor(rivetkit-core): remove prevent_sleep field and deprecate set_prevent_sleep to no-op #4741
• fix(api-public): remove orphan import_export actors module #4764
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review for test(rivetkit): cover c.db access from onWake/onSleep/onDestroy

SUMMARY

This PR extends the db-init-order test fixture to verify that c.db is accessible from onWake, onSleep, and onDestroy lifecycle hooks. It refactors initOrderProvider() to eliminate repetition.

WHAT IS DONE WELL

• DRY refactor: initOrderProvider() returns a fresh db() config instance per call
• Test isolation: UUID-based actor keys + fresh spawned process per test, no cross-contamination
• Observer actor pattern: dbInitOrderObserver avoids resetting the sleep deadline on the actor under test
• No vi.mock or jest.mock usage; no new vi.waitFor calls

ISSUES

1. Missing sleep-skip guard on sleep-dependent tests (Actionable)

The onWake and onSleep tests depend on actor sleep but are not guarded by a skip condition. Other sleep tests consistently use describe.skipIf(driverTestConfig.skip?.sleep) or equivalent (see actor-run.test.ts:9, actor-workflow.test.ts:387, actor-sleep-db.test.ts:114). The onDestroy test does not involve sleep and is fine. The two sleep-dependent tests should be wrapped for forward-compatibility with driver variants that disable sleep.

File: rivetkit-typescript/packages/rivetkit/tests/driver/actor-db-init-order.test.ts:60-155

2. Polling the sleeping actor can reset the sleep deadline (Minor)

CLAUDE.md states: Driver tests that wait for actor sleep must not poll actor actions while waiting. In the onWake test, after waitFor(150ms), there is a loop calling actor.getWakeCount() every 25ms (actor-db-init-order.test.ts:77-81). Under CI load this could reset the sleep deadline before the actor sleeps. The same pattern exists in actor-run.test.ts so it is not a new regression.

3. Static observer key across encoding variants (Low)

Both onSleep and onDestroy tests use the hardcoded key db-init-order-observer (actor-db-init-order.test.ts:92, 132). Tests run sequentially in isolated namespaces so no collision occurs today, but a UUID suffix would make isolation explicit.

NO ISSUES FOUND

• Registry registration in registry-static.ts is correct; all four new actors imported and registered
• initOrderProvider() correctly produces a fresh db() instance per call
• scheduleActorSleep follows the established import pattern
• Module-level Maps are test-only; fresh processes per test keep them empty

RECOMMENDED CHANGES

1. Wrap the two sleep-dependent tests with test.skipIf(driverTestConfig.skip?.sleep) for forward compatibility
2. Consider appending crypto.randomUUID() to the observer key to make isolation explicit

Overall this is a solid, well-structured test addition. The main actionable item is adding the sleep-skip guard.

[github-actions]

Preview packages published to npm

Install with:

npm install rivetkit@pr-4786

All packages published as 0.0.0-pr.4786.a7c25b1 with tag pr-4786.

Engine binary is shipped via @rivetkit/engine-cli on linux-x64-musl, linux-arm64-musl, darwin-x64, and darwin-arm64. Windows users should use the release installer or set RIVET_ENGINE_BINARY.

Docker images:

docker pull rivetdev/engine:slim-a7c25b1
docker pull rivetdev/engine:full-a7c25b1

Individual packages

npm install rivetkit@pr-4786
npm install @rivetkit/react@pr-4786
npm install @rivetkit/rivetkit-napi@pr-4786
npm install @rivetkit/workflow-engine@pr-4786