fix(envoy-protocol): advertise current protocol version

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(envoy-protocol): advertise current protocol version #4800 👈 (View in Graphite)
• fix(guard): serialize gateway actor keys correctly #4655 : 1 other dependent PR (#4801 )
• chore(rivetkit): remove inline tests #4668 : 1 other dependent PR (#4657 )
• fix(api): subscribe before namespace workflow dispatch #4654
• fix(rivetkit): restore hibernatable sockets and hydrate serverless starts #4658
• test(rivetkit): stabilize actor db driver tests #4664 : 1 other dependent PR (#4656 )
• fix(test): stabilize lifecycle, sleep, queue, and run edge cases #4660 : 1 other dependent PR (#4665 )
• test(rivetkit): re-enable gateway URL and direct-registry coverage #4659
• fix(rivetkit): keep internal error exposure behavior consistent #4661
• fix(rivetkit): add lifecycle error retry and gateway HTTP routing #4666
• fix(rivetkit-core): remove legacy timeouts #4799
• chore: add CLAUDE.md guidance on test fixtures, SDK regen, and TS client layer #4796
• fix(inspector): stream patched state updates #4795
• fix(rivetkit): refresh stale actor handles #4794
• test(rivetkit-napi): move private tests to crate root #4793
• test(rivetkit-core): move private tests to crate root #4792
• test(runner-configs): assert envoy protocol version #4791
• fix(serverless): split metadata protocol errors #4789 : 1 other dependent PR (#4790 )
• chore(sqlite): add open close lifecycle for envoy actors #4788
• fix(rivetkit): share lifecycle shutdown grace #4810
• fix(pegboard): move sqlite v1 migration into actor workflow #4787 : 1 other dependent PR (#4797 )
• test(rivetkit): cover c.db access from onWake/onSleep/onDestroy #4786
• fix(rivetkit-napi): run onMigrate before createState/onCreate/createVars #4785
• refactor(rivetkit-core): merge ready+started into lifecycle_started, drop redundant napi calls #4784
• fix(rivetkit): drain native sleep side tasks reliably #4782 : 1 other dependent PR (#4783 )
• fix(rivetkit): route raw request fetches to actors #4781
• fix(pegboard): refresh runner config after envoy connect #4778 : 2 other dependent PRs (#4779 , #4798 )
• chore(kitchen-sink): configurable endpoint #4766 : 2 other dependent PRs (#4754 , #4777 )
• refactor(rivetkit-core): rename StopReason to ShutdownKind and kill enum fallthroughs #4765
• chore(envoy-client): log command and event payloads #4751
• fix(rivetkit): minor sleep-cleanup follow-ups #4761
• docs(rivetkit): clean up stale setPreventSleep references in docs and JSDoc #4760
• docs(rivetkit): document keepAwake/waitUntil counter-arm race and surface bridge errors #4759
• test(engine): force overdue branch in alarm-during-sleep test with negative offset #4758
• fix(rivetkit-core): return stopping not starting when sleep/destroy called mid-shutdown #4757
• test(rivetkit): remove sleepWithPreventSleep fixture and tests #4756
• test(engine): add regression test for alarm-during-sleep-transition race #4755
• test(rivetkit-core): cover sleep/destroy guards and prevent_sleep no-op #4750
• docs: add keepAwake vs waitUntil table and internal sleep-sequence invariants #4749
• feat(rivetkit): expose c.keepAwake(promise) through native path #4748
• refactor(rivetkit): deprecate setPreventSleep to no-op in TypeScript #4747
• fix(rivetkit-core): enumerate non-drained counters in grace deadline warn log #4746
• fix(rivetkit-core): abort graceful cleanup task when grace deadline elapses #4745
• fix(rivetkit-core): error on sleep/destroy before startup or already-requested #4743
• fix(rivetkit-core): cap SerializeState shutdown timeout at 15s #4742
• refactor(rivetkit-core): remove prevent_sleep field and deprecate set_prevent_sleep to no-op #4741
• fix(api-public): remove orphan import_export actors module #4764
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: fix(envoy-protocol): advertise current protocol version

Scope: Single file — engine/sdks/rust/envoy-protocol/src/versioned.rs, 12 additions / 12 deletions. All six OwnedVersionedData impls (ToEnvoy, ToRivet, ToGateway, ToOutbound, ToEnvoyConn, ActorCommandKeyData) change their deserialize_converters() and serialize_converters() from vec![Ok] to vec![Ok, Ok].

---

The fix is correct

vbare::OwnedVersionedData uses converters.len() + 1 to determine the advertised protocol version. vec![Ok] (length 1) advertised version 2; vec![Ok, Ok] (length 2) correctly advertises version 3, matching PROTOCOL_VERSION: u16 = 3 in lib.rs. The actual per-version migration logic already lives in deserialize_version() / serialize_version(), so identity (Ok) converters are appropriate here. All six types are updated consistently.

---

Issues and Suggestions

1. Missing invariant test

No test asserts that the converter-length-derived "current version" matches PROTOCOL_VERSION. A regression to vec![Ok] or vec![Ok, Ok, Ok] would silently pass all existing tests. Consider adding a test that locks this for all future bumps:

#[test]
fn all_message_types_advertise_current_protocol_version() {
    assert_eq!(ToEnvoy::current_version(), PROTOCOL_VERSION);
    assert_eq!(ToRivet::current_version(), PROTOCOL_VERSION);
    assert_eq!(ToGateway::current_version(), PROTOCOL_VERSION);
    assert_eq!(ToOutbound::current_version(), PROTOCOL_VERSION);
    assert_eq!(ToEnvoyConn::current_version(), PROTOCOL_VERSION);
    assert_eq!(ActorCommandKeyData::current_version(), PROTOCOL_VERSION);
}

(Verify the exact vbare method name at https://docs.rs/vbare.)

2. Existing tests are inline (pre-existing violation)

Root CLAUDE.md states: "Rust tests live under tests/, not inline #[cfg(test)] mod tests in src/." The three existing tests in versioned.rs are inline. This PR doesn't introduce the violation, but any new test added here should move all tests to engine/sdks/rust/envoy-protocol/tests/versioned.rs rather than compounding it.

3. PR description is boilerplate

The description is the unmodified PR template. A brief note on the observable breakage (e.g., envoy and pegboard negotiating v2 instead of v3, causing command KV keys to use the wrong schema) would help reviewers assess impact and help future readers understand the operational context of the change.

---

No concerns on

• Style and formatting are consistent with surrounding code and the vbare usage patterns elsewhere in the repo (e.g., epoxy-protocol/src/versioned.rs, data/src/versioned/namespace_runner_config.rs).
• No new public API surface, no security impact.
• Change is minimal and scoped precisely to the affected impls.
• CLAUDE.md rule to never modify an existing published *.bare runner protocol version is respected — this only updates the converter registration, not the schema itself.