refactor(sqlite-storage): extract DBHead to vbare-versioned protocol crate#4815
Conversation
PR Review: refactor(sqlite-storage): extract DBHead to vbare-versioned protocol crateOverviewThis PR extracts Critical: Breaking On-Disk Format ChangeThe old encoding stored Any existing actor SQLite meta records written by the old code will fail to decode:
The old Action required: Either confirm that existing stored data is always wiped on upgrade (pre-release only), or add a migration bridge in Convention: Free Function vs. Extension Trait
Minor: Unnecessary Clone in
|
| Severity | Issue |
|---|---|
| Critical | On-disk format break: old serde_bare blobs fail to decode with the new versioned encoder; backward-compat fallback removed |
| Moderate | Free function new_db_head should be an extension trait per project convention |
| Minor | Unnecessary clone() in types::encode_db_head wrapper |
The core refactoring direction is sound. The format-compatibility concern needs to be resolved (or explicitly acknowledged as intentional for a pre-release wipe) before merging.
2d28410 to
d55b8cf
Compare
6a0ae51 to
5c43398
Compare
d55b8cf to
40f9e0b
Compare
5c43398 to
57aa81f
Compare
40f9e0b to
76265f2
Compare
57aa81f to
3bb9717
Compare
76265f2 to
9293029
Compare
9b501ed to
58ff56b
Compare
2c9727e to
cd5775d
Compare
3d61f72 to
6d1d4e3
Compare
6d1d4e3 to
ee84fb7
Compare
20a8181 to
cfbcbfd
Compare
cfbcbfd to
a36c978
Compare
ee84fb7 to
0c85098
Compare
|
Landed in main via stack-merge fast-forward push. Commits are in main; closing to match. |
Preview packages published to npmInstall with: npm install rivetkit@pr-4815All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-3b70228
docker pull rivetdev/engine:full-3b70228Individual packagesnpm install rivetkit@pr-4815
npm install @rivetkit/react@pr-4815
npm install @rivetkit/rivetkit-napi@pr-4815
npm install @rivetkit/workflow-engine@pr-4815 |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: