test(rivetkit-napi): move private tests to crate root

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(test): stabilize lifecycle, sleep, queue, and run edge cases #4660 : 2 dependent PRs (#4664 , #4665 )
• test(rivetkit): re-enable gateway URL and direct-registry coverage #4659
• fix(rivetkit): keep internal error exposure behavior consistent #4661
• fix(rivetkit): add lifecycle error retry and gateway HTTP routing #4666
• fix(rivetkit-core): remove legacy timeouts #4799
• chore: add CLAUDE.md guidance on test fixtures, SDK regen, and TS client layer #4796
• fix(inspector): stream patched state updates #4795
• fix(rivetkit): refresh stale actor handles #4794
• test(rivetkit-napi): move private tests to crate root #4793 👈 (View in Graphite)
• test(rivetkit-core): move private tests to crate root #4792
• test(runner-configs): assert envoy protocol version #4791
• fix(serverless): split metadata protocol errors #4789 : 1 other dependent PR (#4790 )
• chore(sqlite): add open close lifecycle for envoy actors #4788
• fix(rivetkit): share lifecycle shutdown grace #4810
• fix(pegboard): move sqlite v1 migration into actor workflow #4787 : 1 other dependent PR (#4797 )
• test(rivetkit): cover c.db access from onWake/onSleep/onDestroy #4786
• fix(rivetkit-napi): run onMigrate before createState/onCreate/createVars #4785
• refactor(rivetkit-core): merge ready+started into lifecycle_started, drop redundant napi calls #4784
• fix(rivetkit): drain native sleep side tasks reliably #4782 : 1 other dependent PR (#4783 )
• fix(rivetkit): route raw request fetches to actors #4781
• fix(pegboard): refresh runner config after envoy connect #4778 : 2 other dependent PRs (#4779 , #4798 )
• chore(kitchen-sink): configurable endpoint #4766 : 2 other dependent PRs (#4754 , #4777 )
• refactor(rivetkit-core): rename StopReason to ShutdownKind and kill enum fallthroughs #4765
• chore(envoy-client): log command and event payloads #4751
• fix(rivetkit): minor sleep-cleanup follow-ups #4761
• docs(rivetkit): clean up stale setPreventSleep references in docs and JSDoc #4760
• docs(rivetkit): document keepAwake/waitUntil counter-arm race and surface bridge errors #4759
• test(engine): force overdue branch in alarm-during-sleep test with negative offset #4758
• fix(rivetkit-core): return stopping not starting when sleep/destroy called mid-shutdown #4757
• test(rivetkit): remove sleepWithPreventSleep fixture and tests #4756
• test(engine): add regression test for alarm-during-sleep-transition race #4755
• test(rivetkit-core): cover sleep/destroy guards and prevent_sleep no-op #4750
• docs: add keepAwake vs waitUntil table and internal sleep-sequence invariants #4749
• feat(rivetkit): expose c.keepAwake(promise) through native path #4748
• refactor(rivetkit): deprecate setPreventSleep to no-op in TypeScript #4747
• fix(rivetkit-core): enumerate non-drained counters in grace deadline warn log #4746
• fix(rivetkit-core): abort graceful cleanup task when grace deadline elapses #4745
• fix(rivetkit-core): error on sleep/destroy before startup or already-requested #4743
• fix(rivetkit-core): cap SerializeState shutdown timeout at 15s #4742
• refactor(rivetkit-core): remove prevent_sleep field and deprecate set_prevent_sleep to no-op #4741
• fix(api-public): remove orphan import_export actors module #4764
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR #4793 Review: Move private tests to crate root tests/

Overview

This PR moves inline #[cfg(test)] mod tests blocks from three rivetkit-napi source files into corresponding files under tests/. Because the crate is cdylib-only (no lib target), true Cargo integration tests can't link against it, so the approach uses #[path = "../tests/..."] shims to physically place the code in tests/ while keeping it compiled as inline module tests. autotests = false is added to prevent Cargo from mistakenly trying to build those files as standalone integration test binaries.

Issues

Bug: core_ctx.set_started(true) silently dropped in run_adapter_loop_resets_stale_shared_end_reason_before_wake

The original test in src/napi_actor_events.rs sets up the stale actor state like this:

let stale_ctx = ActorContext::new(core_ctx.clone());
core_ctx.set_started(true);   // sets started=true on the shared inner Arc
stale_ctx.set_end_reason(EndReason::Sleep);

The moved test in tests/napi_actor_events.rs omits the set_started call:

let stale_ctx = ActorContext::new(core_ctx.clone());
stale_ctx.set_end_reason(EndReason::Sleep);

Since core_ctx.clone() is an Arc clone, both handles share the same inner state, so set_started(true) was establishing the precondition that the actor had previously been running. Dropping it changes the test's setup and could allow the test to pass for the wrong reason or miss a real regression. This should be restored.

Unnecessary mod moved_tests nesting

Every test file introduces a gratuitous extra module:

use super::*;

mod moved_tests {   // not needed
    use super::*;
    ...
}

The name moved_tests leaks an implementation detail and adds an extra indirection that makes stack traces and cargo test filter paths harder to read (tests become tests::moved_tests::foo instead of tests::foo). The outer use super::*; at file scope is also redundant since nothing uses it there. The tests could live directly at the file root, mirroring the original mod tests { ... } layout:

// tests/actor_context.rs
use super::*;

#[test]
fn reset_runtime_state_clears_end_reason_without_touching_core_lifecycle_flags() { ... }

Missing explanation for autotests = false

The Cargo.toml change is a non-obvious footgun: someone who later adds a normal tests/ integration test will wonder why it never runs. A brief inline comment explaining the cdylib/#[path] coupling would prevent future confusion:

autotests = false  # tests/ files are #[path] shims, not standalone binaries (cdylib has no lib target)

Comment style nit (CLAUDE.md § Comments)

The shim comments use a dash-separated fragment structure. Per project convention, write as a normal complete sentence ending with a period: // Tests live in tests/ via #[path] to keep private-module access while satisfying the crate test layout rule.

What's Good

• The motivation is sound: CLAUDE.md mandates tests live in tests/; this crate tests private internals that can't be reached from a true integration binary; the #[path] shim is the correct workaround.
• autotests = false prevents a silent breakage where Cargo would try (and fail) to link the tests/ files as standalone binaries.
• All test logic is preserved and the tests are functionally identical — except for the one dropped set_started line noted above.

Summary

The approach is architecturally correct. There is one real defect (dropped set_started call that changes a test's precondition), one readability issue (superfluous mod moved_tests wrapper that clutters test output paths), and a few minor comment/documentation nits. The dropped call is the only change that could affect test correctness and should be fixed before merging.

[github-actions]

Preview packages published to npm

Install with:

npm install rivetkit@pr-4793

All packages published as 0.0.0-pr.4793.d6c7015 with tag pr-4793.

Engine binary is shipped via @rivetkit/engine-cli on linux-x64-musl, linux-arm64-musl, darwin-x64, and darwin-arm64. Windows users should use the release installer or set RIVET_ENGINE_BINARY.

Docker images:

docker pull rivetdev/engine:slim-d6c7015
docker pull rivetdev/engine:full-d6c7015

Individual packages

npm install rivetkit@pr-4793
npm install @rivetkit/react@pr-4793
npm install @rivetkit/rivetkit-napi@pr-4793
npm install @rivetkit/workflow-engine@pr-4793

[NathanFlurry]

Landed in main via stack-merge fast-forward push. Commits are in main; closing to match.