test(rivetkit): re-enable gateway URL and direct-registry coverage

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(test): stabilize lifecycle, sleep, queue, and run edge cases #4660 : 2 dependent PRs (#4664 , #4665 )
• test(rivetkit): re-enable gateway URL and direct-registry coverage #4659 👈 (View in Graphite)
• fix(rivetkit): keep internal error exposure behavior consistent #4661
• fix(rivetkit): add lifecycle error retry and gateway HTTP routing #4666
• fix(rivetkit-core): remove legacy timeouts #4799
• chore: add CLAUDE.md guidance on test fixtures, SDK regen, and TS client layer #4796
• fix(inspector): stream patched state updates #4795
• fix(rivetkit): refresh stale actor handles #4794
• test(rivetkit-napi): move private tests to crate root #4793
• test(rivetkit-core): move private tests to crate root #4792
• test(runner-configs): assert envoy protocol version #4791
• fix(serverless): split metadata protocol errors #4789 : 1 other dependent PR (#4790 )
• chore(sqlite): add open close lifecycle for envoy actors #4788
• fix(rivetkit): share lifecycle shutdown grace #4810
• fix(pegboard): move sqlite v1 migration into actor workflow #4787 : 1 other dependent PR (#4797 )
• test(rivetkit): cover c.db access from onWake/onSleep/onDestroy #4786
• fix(rivetkit-napi): run onMigrate before createState/onCreate/createVars #4785
• refactor(rivetkit-core): merge ready+started into lifecycle_started, drop redundant napi calls #4784
• fix(rivetkit): drain native sleep side tasks reliably #4782 : 1 other dependent PR (#4783 )
• fix(rivetkit): route raw request fetches to actors #4781
• fix(pegboard): refresh runner config after envoy connect #4778 : 2 other dependent PRs (#4779 , #4798 )
• chore(kitchen-sink): configurable endpoint #4766 : 2 other dependent PRs (#4754 , #4777 )
• refactor(rivetkit-core): rename StopReason to ShutdownKind and kill enum fallthroughs #4765
• chore(envoy-client): log command and event payloads #4751
• fix(rivetkit): minor sleep-cleanup follow-ups #4761
• docs(rivetkit): clean up stale setPreventSleep references in docs and JSDoc #4760
• docs(rivetkit): document keepAwake/waitUntil counter-arm race and surface bridge errors #4759
• test(engine): force overdue branch in alarm-during-sleep test with negative offset #4758
• fix(rivetkit-core): return stopping not starting when sleep/destroy called mid-shutdown #4757
• test(rivetkit): remove sleepWithPreventSleep fixture and tests #4756
• test(engine): add regression test for alarm-during-sleep-transition race #4755
• test(rivetkit-core): cover sleep/destroy guards and prevent_sleep no-op #4750
• docs: add keepAwake vs waitUntil table and internal sleep-sequence invariants #4749
• feat(rivetkit): expose c.keepAwake(promise) through native path #4748
• refactor(rivetkit): deprecate setPreventSleep to no-op in TypeScript #4747
• fix(rivetkit-core): enumerate non-drained counters in grace deadline warn log #4746
• fix(rivetkit-core): abort graceful cleanup task when grace deadline elapses #4745
• fix(rivetkit-core): error on sleep/destroy before startup or already-requested #4743
• fix(rivetkit-core): cap SerializeState shutdown timeout at 15s #4742
• refactor(rivetkit-core): remove prevent_sleep field and deprecate set_prevent_sleep to no-op #4741
• fix(api-public): remove orphan import_export actors module #4764
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review (updated): test(rivetkit): re-enable gateway URL and direct-registry coverage

This is an updated review reflecting the latest changes.

Summary

This PR re-enables two test suites (raw-http-direct-registry and raw-websocket-direct-registry), rewrites driver-engine-ping.test.ts to use the serverless runner pattern, adds a waitForClientWarmup readiness barrier, adds retry logic to refreshRunnerMetadata, re-enables the dynamic registry test variant, and switches engine driver tests to describe.sequential.

---

Significant: Silent swallow of refreshRunnerMetadata errors

In driver-engine.test.ts (~line 196), all errors from refreshRunnerMetadata are caught and discarded. A permanent failure (wrong token, misconfigured endpoint) will be invisible and any downstream test failure will be misattributed. Consider logging the caught error at warn level so the CI trace retains a breadcrumb without blocking setup.

Significant: Non-null assertion on serverlessHandleStart

In src/test/mod.ts (~line 168) and driver-engine-ping.test.ts, the call actorDriver.serverlessHandleStart!(ctx) will throw an unhelpful TypeError if the driver does not implement this method. A guard returning HTTP 501 with a clear message would make failures immediately actionable.

Moderate: Duplicated helpers across test files

refreshRunnerMetadata and closeNodeServer appear in src/test/mod.ts, driver-engine.test.ts, and driver-engine-ping.test.ts. waitForOpen appears in driver-engine-ping.test.ts and raw-websocket-direct-registry.ts with differing listener cleanup quality (ping file properly cleans up; WebSocket file uses once:true without cleaning the other paths). buildGatewayRequestUrl appears in raw-http-direct-registry.ts and driver-engine-ping.test.ts with differing double-prefix guards. These should be consolidated into a shared tests/engine-test-utils.ts.

Moderate: serverless config block duplicated verbatim

The serverless runner config block is duplicated between src/test/mod.ts (~line 185) and driver-engine-ping.test.ts (~line 1665). Extracting it into a shared constant prevents the copies from diverging silently.

Minor: waitForClientWarmup uses a fixed key across parallel tests

The constant key driver-test-warmup works today because each test has its own namespace/pool, but a per-test ID would make isolation explicit and robust against future config changes.

Minor: Retry sleep uses raw setTimeout instead of antiox

Per CLAUDE.md, antiox is the preferred TypeScript concurrency primitive. The retry loops in refreshRunnerMetadata use raw setTimeout directly.

Minor: Missing conn_params test in the HTTP gateway suite

raw-http-direct-registry.ts does not include a conn_params test (the old code had one via HEADER_CONN_PARAMS). The WebSocket suite does test conn params. If the HTTP gateway path supports conn_params, this coverage gap should be tracked.

---

Positive Observations

• waitForClientWarmup with a ping() action on a dedicated warmup actor is a much cleaner readiness barrier than the previous setTimeout(250).
• describe.sequential for the engine driver suite is correct for tests that share a single engine process.
• buildGatewayWebSocketUrl in raw-websocket-direct-registry.ts properly handles query-string passthrough.
• AbortSignal.timeout(2_000) per retry attempt in refreshRunnerMetadata prevents a single stalled request from consuming the full retry budget.
• Re-enabling the dynamic registry variant closes genuine coverage that was dark.
• Namespace creation with 409-tolerance in ensureNamespaceExists is correct for idempotent test setup.

Review generated by Claude Sonnet 4.6

[claude]

PR 4659 Review: test(rivetkit) re-enable gateway URL and direct-registry coverage

Overview

This PR adds two new test scenarios to the engine driver smoke test suite and a minimal warmupActor fixture:

1. HTTP ping via gateway URL - exercises the getGatewayUrl() routing to /request/<path>
2. WebSocket echo via gateway URL - exercises the getGatewayUrl() routing to /websocket/<path>
3. warmupActor fixture - a minimal actor with a single ping action, added to the static registry

---

Issues

Unexplained initial-message wait before sending ping

In the new WebSocket gateway test, an await new Promise waits for an incoming message before the ping is sent. The original non-gateway WebSocket test sends the ping immediately after waitForOpen with no initial-message wait. If the gateway or actor does not send anything on connect, this promise will never resolve and the test will time out. If it does send something (e.g. a connection-ack frame), that behavior needs a comment explaining it.

Suggestion: Add a comment such as // wait for connection-ack from gateway or remove the block if not needed.

Listener registered after send (pre-existing, worth noting)

In both the existing and new WebSocket tests, the message listener for the pong is registered after ws.send is called. In practice this works because network RTT keeps the reply from arriving before the microtask registers the listener, but it is a latent race. The safer pattern is to register the listener before sending.

No cleanup on failure

ws.close() is called at the end of each test but is not guarded by try/finally. If the test throws before reaching ws.close(), the connection leaks. A try/finally or Vitest onTestFinished would be safer. The same issue exists in the pre-existing tests; fixing them in the same change would be a clean-up win.

warmupActor purpose is unclear

warmupActor is added to the static registry but is not referenced in any of the new tests. A short comment in registry-static.ts or warmup.ts explaining why this actor exists would help future readers.

---

Minor Observations

• buildGatewayRequestUrl / buildGatewayWebSocketUrl - clean URL manipulation using new URL(), good practice.
• encodings: json filter - limiting gateway tests to JSON encoding is reasonable for path-routing coverage.
• waitForOpen - correct; no TOCTOU risk in single-threaded JS since listener registration and readyState check are synchronous.
• Fixture structure - actors/warmupActor.ts re-exporting from ../warmup.ts matches the existing pattern in the fixture directory.

---

Summary

The main concern is the unexplained initial-message await in the WebSocket gateway test. If the actor/gateway does not send a frame on connect, the test will hang. The other points (listener ordering, missing try/finally) are lower priority. The warmupActor needs a comment explaining its purpose.

[NathanFlurry]

Landed in main via stack-merge fast-forward push. Commits are in main; closing to match.