Skip to content

docs(rivetkit): clean up stale setPreventSleep references in docs and JSDoc#4760

Merged
NathanFlurry merged 1 commit intomainfrom
sleep-cleanup/15-stale-prevent-sleep-refs
Apr 27, 2026
Merged

docs(rivetkit): clean up stale setPreventSleep references in docs and JSDoc#4760
NathanFlurry merged 1 commit intomainfrom
sleep-cleanup/15-stale-prevent-sleep-refs

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 24, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude Bot commented Apr 24, 2026

Code Review: docs(rivetkit): clean up stale setPreventSleep references

Overview

Small docs-only cleanup PR (9 additions, 8 deletions) that replaces all stale references to the removed c.setPreventSleep(true) API with the current c.keepAwake(promise) API across JSDoc comments and documentation pages.

Changes Reviewed

  • actor/config.ts — Two JSDoc/describe strings updated for the deprecated noSleep option
  • workflow/context.ts — JSDoc for waitUntil rewritten
  • limits.mdx, versions.mdx — Sleep grace period descriptions updated
  • architecture.mdx — Architecture overview bullet updated

Looks Good

  • All setPreventSleep references correctly replaced with keepAwake(promise)
  • The noSleep deprecation message still correctly points users to keepAwake
  • Architecture, limits, and versions docs are now consistent with the actual API

One Item to Verify

waitUntil is no longer marked @deprecated — The old JSDoc on waitUntil in workflow/context.ts carried @deprecated, but the new comment is a regular description with no deprecation tag. If this is intentional (restoring waitUntil as a supported API alongside keepAwake), the change is fine and the new description is accurate. If waitUntil is still meant to be deprecated, the @deprecated tag should be added back to the new comment.

The new description itself is clear and correct either way.

Minor Note

The limits.mdx and versions.mdx sleep grace period rows now list keepAwake inline with onSleep and waitUntil. This matches the old wording that included "waiting for preventSleep to clear after shutdown starts", so the semantic intent appears correct.


Overall: Clean, accurate cleanup. Ready to merge once the waitUntil deprecation intent is confirmed.

@NathanFlurry NathanFlurry force-pushed the sleep-cleanup/15-stale-prevent-sleep-refs branch from 97055a6 to 1b59a25 Compare April 24, 2026 13:16
@NathanFlurry NathanFlurry force-pushed the sleep-cleanup/14-document-counter-arm-race branch from c76a37f to 3d62102 Compare April 24, 2026 13:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Preview packages published to npm

Install with:

npm install rivetkit@pr-4760

All packages published as 0.0.0-pr.4760.baefe0f with tag pr-4760.

Engine binary is shipped via @rivetkit/engine-cli on linux-x64-musl, linux-arm64-musl, darwin-x64, and darwin-arm64. Windows users should use the release installer or set RIVET_ENGINE_BINARY.

Docker images:

docker pull rivetdev/engine:slim-baefe0f
docker pull rivetdev/engine:full-baefe0f
Individual packages
npm install rivetkit@pr-4760
npm install @rivetkit/react@pr-4760
npm install @rivetkit/rivetkit-napi@pr-4760
npm install @rivetkit/workflow-engine@pr-4760

@NathanFlurry NathanFlurry force-pushed the sleep-cleanup/14-document-counter-arm-race branch from 3d62102 to 8635c7d Compare April 26, 2026 02:34
@NathanFlurry NathanFlurry force-pushed the sleep-cleanup/15-stale-prevent-sleep-refs branch from 1b59a25 to 6c72f57 Compare April 26, 2026 02:34
Base automatically changed from sleep-cleanup/14-document-counter-arm-race to main April 27, 2026 07:13
@NathanFlurry NathanFlurry merged commit 6c72f57 into main Apr 27, 2026
41 of 52 checks passed
@NathanFlurry NathanFlurry deleted the sleep-cleanup/15-stale-prevent-sleep-refs branch April 27, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant