Skip to content

chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring#4641

Merged
NathanFlurry merged 1 commit intomainfrom
chore/remove-sqlite-vfs-packages
Apr 24, 2026
Merged

chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring#4641
NathanFlurry merged 1 commit intomainfrom
chore/remove-sqlite-vfs-packages

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude Bot commented Apr 13, 2026

PR Review: chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring

Overview

This PR removes the WASM SQLite VFS implementation (@rivetkit/sqlite-wasm / sqlite-vfs package and related test package) from the monorepo, along with three internal documentation files. Net change: −8,622 / +409 lines, almost entirely deletions.


Blocking Concern

@rivetkit/engine-api-full override points to a pkg.pr.new preview URL (pnpm-lock.yaml)

-  '@rivetkit/engine-api-full': workspace:*
+  '@rivetkit/engine-api-full': https://pkg.pr.new/rivet-dev/engine-ee/@rivetkit/engine-api-full@011e389

This resolves to a specific preview-package commit and should not land in main. pkg.pr.new URLs expire and cannot be reproduced from source. This looks like a temporary local testing artefact that was accidentally committed. It should be reverted to workspace:* (or the correct workspace path) before merging.


Code Quality & Correctness

  • Removals are clean. Every deleted file is internally consistent: the VFS source, pool, KV helpers, schemas, test suite, build scripts, and Dockerfiles all change together. No dangling references were spotted.
  • examples/sandbox/package.json correctly switches @rivetkit/react from workspace:^ to "*" per CLAUDE.md convention for examples. Good.
  • Cargo.lock bumps (anyhow, bitflags, bumpalo, cc) are routine patch/minor version updates with no API changes expected.

Test Coverage

The removed packages contained ~700 lines of well-structured tests:

  • sqlite-vfs.test.ts — read/write/truncate/delete-range correctness, multi-chunk boundary cases, BATCH_ATOMIC fallback
  • pool.test.ts — actor-to-instance assignment, short-name reuse, idle destroy, poisoned short names
  • sqlite-lock-repro.test.ts — regression test for the Node.js SQLite exclusive lock bug

No replacement tests are added for the native SQLite path in this PR. This is acceptable if the native backend already has its own test suite, but it should be confirmed before merging.

Missing PR Description

The PR template was not filled in — summary, test description, and all checklist items are blank. A brief description of why the WASM VFS is being removed (e.g., superseded by @rivetkit/sqlite-native, no longer used by any consumer) would help reviewers and future git log readers.


Summary

Blocking @rivetkit/engine-api-full pkg.pr.new URL must be reverted before merge
Non-blocking PR description should be filled out
Non-blocking Confirm native SQLite path has equivalent test coverage

The structural cleanup itself is correct and well-scoped. The single blocking issue is the accidentally committed pkg.pr.new resolution for @rivetkit/engine-api-full.

@NathanFlurry NathanFlurry force-pushed the chore/remove-sqlite-vfs-packages branch from f66e9f8 to f937ba3 Compare April 24, 2026 07:33
Base automatically changed from chore/remove-wasm-sqlite-native-only to main April 24, 2026 07:38
@NathanFlurry NathanFlurry merged commit f937ba3 into main Apr 24, 2026
7 of 16 checks passed
@NathanFlurry NathanFlurry deleted the chore/remove-sqlite-vfs-packages branch April 24, 2026 07:39
This was referenced Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant