fix(rivetkit): drop is_read_only_sql classifier, surface RETURNING rows#4728
Conversation
|
PR Review: fix(rivetkit): drop is_read_only_sql classifier, surface RETURNING rows - This PR is currently in DRAFT. Overview: Removes the heuristic-based read-only SQL classifier and replaces it with a unified db_query path, correctly surfacing RETURNING clause rows. Correctness: The old classifier was wrong for WITH (can contain DML), and RETURNING on INSERT/UPDATE/DELETE was silently dropped. Using db_query for all statements is correct SQLite behavior. Code quality: Clean simplification, both Rust and TS updated for parity, decode_cbor_json_or_null handles empty results gracefully. Concern: db_run is now unused from the inspector path - worth checking it is not dead code. Main gap: no regression test for RETURNING behavior. Consider adding a driver-test before marking ready. |
Preview packages published to npmInstall with: npm install rivetkit@pr-4728All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-46b51d3
docker pull rivetdev/engine:full-46b51d3Individual packagesnpm install rivetkit@pr-4728
npm install @rivetkit/react@pr-4728
npm install @rivetkit/rivetkit-napi@pr-4728
npm install @rivetkit/workflow-engine@pr-4728 |
c6ef795 to
6502fc1
Compare
e1adad5 to
25a263c
Compare
6502fc1 to
6ac729a
Compare
25a263c to
2c0ba8a
Compare
6ac729a to
c02368f
Compare
2c0ba8a to
a512a8f
Compare
a512a8f to
b3d5c95
Compare
c02368f to
a7011b4
Compare
b3d5c95 to
95ff109
Compare
a7011b4 to
84c1d02
Compare
84c1d02 to
d4cb14c
Compare
95ff109 to
14947c2
Compare
d4cb14c to
c4e501a
Compare
14947c2 to
048de9b
Compare
048de9b to
d47c579
Compare
|
Landed in main via stack-merge fast-forward push. Commits are in main; closing to match. |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: