Skip to content

fix(rivetkit): drop is_read_only_sql classifier, surface RETURNING rows#4728

Closed
NathanFlurry wants to merge 1 commit into04-23-docs_require_close-code_rejection_for_websocket_auth_policy_failuresfrom
04-23-fix_rivetkit_drop_is_read_only_sql_classifier_surface_returning_rows
Closed

fix(rivetkit): drop is_read_only_sql classifier, surface RETURNING rows#4728
NathanFlurry wants to merge 1 commit into04-23-docs_require_close-code_rejection_for_websocket_auth_policy_failuresfrom
04-23-fix_rivetkit_drop_is_read_only_sql_classifier_surface_returning_rows

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude Bot commented Apr 24, 2026

PR Review: fix(rivetkit): drop is_read_only_sql classifier, surface RETURNING rows - This PR is currently in DRAFT. Overview: Removes the heuristic-based read-only SQL classifier and replaces it with a unified db_query path, correctly surfacing RETURNING clause rows. Correctness: The old classifier was wrong for WITH (can contain DML), and RETURNING on INSERT/UPDATE/DELETE was silently dropped. Using db_query for all statements is correct SQLite behavior. Code quality: Clean simplification, both Rust and TS updated for parity, decode_cbor_json_or_null handles empty results gracefully. Concern: db_run is now unused from the inspector path - worth checking it is not dead code. Main gap: no regression test for RETURNING behavior. Consider adding a driver-test before marking ready.

@github-actions
Copy link
Copy Markdown
Contributor

Preview packages published to npm

Install with:

npm install rivetkit@pr-4728

All packages published as 0.0.0-pr.4728.46b51d3 with tag pr-4728.

Engine binary is shipped via @rivetkit/engine-cli on linux-x64-musl, linux-arm64-musl, darwin-x64, and darwin-arm64. Windows users should use the release installer or set RIVET_ENGINE_BINARY.

Docker images:

docker pull rivetdev/engine:slim-46b51d3
docker pull rivetdev/engine:full-46b51d3
Individual packages
npm install rivetkit@pr-4728
npm install @rivetkit/react@pr-4728
npm install @rivetkit/rivetkit-napi@pr-4728
npm install @rivetkit/workflow-engine@pr-4728

@NathanFlurry NathanFlurry force-pushed the 04-23-docs_require_close-code_rejection_for_websocket_auth_policy_failures branch from 6ac729a to c02368f Compare April 24, 2026 09:52
@NathanFlurry NathanFlurry force-pushed the 04-23-fix_rivetkit_drop_is_read_only_sql_classifier_surface_returning_rows branch from 2c0ba8a to a512a8f Compare April 24, 2026 09:52
@NathanFlurry NathanFlurry mentioned this pull request Apr 24, 2026
11 tasks
@NathanFlurry NathanFlurry force-pushed the 04-23-fix_rivetkit_drop_is_read_only_sql_classifier_surface_returning_rows branch from a512a8f to b3d5c95 Compare April 24, 2026 10:19
@NathanFlurry NathanFlurry force-pushed the 04-23-docs_require_close-code_rejection_for_websocket_auth_policy_failures branch from c02368f to a7011b4 Compare April 24, 2026 10:19
@NathanFlurry NathanFlurry force-pushed the 04-23-fix_rivetkit_drop_is_read_only_sql_classifier_surface_returning_rows branch from b3d5c95 to 95ff109 Compare April 24, 2026 10:32
@NathanFlurry NathanFlurry force-pushed the 04-23-docs_require_close-code_rejection_for_websocket_auth_policy_failures branch from a7011b4 to 84c1d02 Compare April 24, 2026 10:32
@NathanFlurry NathanFlurry force-pushed the 04-23-docs_require_close-code_rejection_for_websocket_auth_policy_failures branch from 84c1d02 to d4cb14c Compare April 24, 2026 11:48
@NathanFlurry NathanFlurry force-pushed the 04-23-fix_rivetkit_drop_is_read_only_sql_classifier_surface_returning_rows branch from 95ff109 to 14947c2 Compare April 24, 2026 11:48
@NathanFlurry NathanFlurry force-pushed the 04-23-docs_require_close-code_rejection_for_websocket_auth_policy_failures branch from d4cb14c to c4e501a Compare April 24, 2026 12:14
@NathanFlurry NathanFlurry force-pushed the 04-23-fix_rivetkit_drop_is_read_only_sql_classifier_surface_returning_rows branch from 14947c2 to 048de9b Compare April 24, 2026 12:14
@NathanFlurry NathanFlurry force-pushed the 04-23-fix_rivetkit_drop_is_read_only_sql_classifier_surface_returning_rows branch from 048de9b to d47c579 Compare April 24, 2026 12:32
@NathanFlurry
Copy link
Copy Markdown
Member Author

Landed in main via stack-merge fast-forward push. Commits are in main; closing to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant