feat: import/export actors#4640
feat: import/export actors#4640NathanFlurry wants to merge 2 commits into04-21-chore_sqlite_v1_to_v2_data_migrationfrom
Conversation
|
🚅 Deployed to the rivet-pr-4640 environment in rivet-frontend
|
PR Review: feat: import/export actorsThis is a well-structured feature with clear design intent. Here are my observations: Correctness & LogicInconsistent actor existence check for keyless actors (potential slow path) Test ID deduplication may pass for wrong reason Architecture & DesignNo actor quiescence before export No archive cleanup / TTL Import archive path is server-local Code QualityDuplicate
Auth on admin endpoints DocumentationThe documentation checklist is unchecked. The new Minor
Overall this is a solid operational tool. The main concerns are the lack of consistency guarantees during live export and the missing documentation. |
63612bc to
e737a39
Compare
e737a39 to
e17239d
Compare
e17239d to
215f3b8
Compare
215f3b8 to
d6d5a69
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: