feat: remove checkout lifecycle from react-native#116
Closed
Conversation
11 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
React Native — Coverage Report
|
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences
branch
from
06f977e to
9863b61
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featremovecheckoutlifecyclefromreact-native
branch
from
9e532d1 to
828ca31
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences
branch
2 times, most recently
from
f84aa0f to
8f6af8c
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featremovecheckoutlifecyclefromreact-native
branch
from
828ca31 to
71ee27b
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences
branch
from
8f6af8c to
9d68bbe
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featremovecheckoutlifecyclefromreact-native
branch
2 times, most recently
from
bebc20f to
05d929e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences
branch
from
9d68bbe to
193682d
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featremovecheckoutlifecyclefromreact-native
branch
2 times, most recently
from
3dc4ea5 to
d6080f8
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featremovecheckoutlifecyclefromreact-native
branch
from
d6080f8 to
ca7804f
Compare
11 tasks
11 tasks
This was referenced May 15, 2026
tiagocandido
approved these changes
May 15, 2026
Contributor
tiagocandido
left a comment
tiagocandido
left a comment
There was a problem hiding this comment.
Review assisted by pair-review
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
This PR is ripping out the checkout lifecycle event handlers across the board that are no longer supported.
Currently swift is missing the CheckoutDelegate and we dont have the methods for cancel and fail so i had to remove them too, will add them back in a follow up
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.