[Swift] Restore CheckoutDelegate with trimmed lifecycle API#131
Open
tiagocandido wants to merge 1 commit into
Conversation
This was referenced May 15, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 15, 2026
tiagocandido
changed the title
tiagocandido
force-pushed
the
05-15-restore_checkoutdelegate_with_trimmed_lifecycle_api
branch
from
d27977c to
7dceb15
Compare
tiagocandido
force-pushed
the
05-15-restore_checkoutdelegate_with_trimmed_lifecycle_api
branch
from
7dceb15 to
86ecd8b
Compare
tiagocandido
force-pushed
the
05-15-restore_checkoutdelegate_with_trimmed_lifecycle_api
branch
from
86ecd8b to
9aa6c02
Compare
| static func syntheticCompleteMessage(orderId: String?) -> String { | ||
| let id = orderId ?? "" | ||
| let orderJson = orderId.map { ",\"order\":{\"id\":\"\($0)\"}" } ?? "" | ||
| return "{\"jsonrpc\":\"2.0\",\"method\":\"ec.complete\"," |
Contributor
There was a problem hiding this comment.
I think with ready we wrapped it up in the protocol lib - seems like this json could be moved over there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Restores the
CheckoutDelegateprotocol on iOS for host-level lifecycle callbacks, trimmed to:checkoutDidCancel()checkoutDidFail(error:)CheckoutDelegatecovers lifecycle outcomes the host app needs to react to (cancel, fail). Completion and link clicks are delivered through the protocol client (CheckoutProtocol.complete,ec.window.open_request), so they're not part of this surface. Recovery is decided internally usingCheckoutError.isRecoverable, andcheckoutDidFail(error:)only fires once the SDK has given up recovering — not on each intermediate failure.UIKit consumers can now observe cancel/fail by passing a delegate to
ShopifyCheckoutKit.present(checkout:from:delegate:client:). SwiftUI still uses.onCancel/.onFail; there's no.delegate(_:)modifier — SwiftUI structs can't hold a weak delegate reliably across recreations.Two related fixes ride along: the library now ships
CheckoutProtocol.Client: CheckoutCommunicationProtocolso consumers don't need a retroactive extension to wire a client intopresent(...), and the iOS recovery webview forwards a partialec.completeto the client on the confirmation page — parity with AndroidFallbackWebView, making the README claim about partial completion during recovery actually true.How to test
Before you merge
Important