Skip to content

feat: add first protocol event#134

Draft
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood/05-14-featexploredynamicdispatchforcheckoutdelegatefrom
kieran-osgood/05-15-feataddfirstprotocolevent
Draft

feat: add first protocol event#134
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood/05-14-featexploredynamicdispatchforcheckoutdelegatefrom
kieran-osgood/05-15-feataddfirstprotocolevent

Conversation

@kieran-osgood-shopify
Copy link
Copy Markdown
Contributor

@kieran-osgood-shopify kieran-osgood-shopify commented May 15, 2026

What changes are you making?

Subscribing to events should look like this

  <CheckoutSheet
        url={checkoutUrl}
        onCancel={() => setVisible(false)}
        onFail={() => {}}
        protocol={{
          start:    chk => analytics.track('checkout_start', { id: chk.id }),
          complete: chk => {
            reset();
            setVisible(false);
          },
          error:    err => toast(err.messages[0]?.content ?? 'Checkout error'),
        }}
      />


 ShopifyCheckoutKit.present(url, {onFail: () => {}, onCancel: () => {}}, { [CheckoutProtocol.start]: c => {c.checkourUrl} })

How to test


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

Copy link
Copy Markdown
Contributor Author

kieran-osgood-shopify commented May 15, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 99%
99.5% (199/200) 95.12% (117/123) 100% (55/55)

@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-14-featexploredynamicdispatchforcheckoutdelegate branch from 2e3e7a2 to ac67cdd Compare May 15, 2026 17:57
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-15-feataddfirstprotocolevent branch from dc33d14 to eb6a44c Compare May 15, 2026 17:57
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-14-featexploredynamicdispatchforcheckoutdelegate branch from ac67cdd to f5efe2e Compare May 15, 2026 18:14
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-15-feataddfirstprotocolevent branch from eb6a44c to 9925167 Compare May 15, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant