fix: improve type map generation#25
Conversation
32364d4 to
25b6cd7
Compare
|
rebased |
|
@TusharThakur04 The issue isn't a matter of rebasing, the Either:
|
|
thanks!! |
|
Hey @avivkeller and @TusharThakur04, great work on getting this merged! However, I wanted to point out a couple of critical URL routing bugs in this implementation that I had actually addressed in my PR (#19):
Since my PR (#19) is now conflicted, I’d be happy to open a quick follow-up PR to patch these two routing edge cases into the new implementation. |
|
That won't happen. That's an issue that existed before this PR, and is not a "critical routing bug". I've resolved it at the source in #26. |
|
Please refrain from pointing out "bugs" in "this implementation" that aren't part of this PR. |
My apologies for the poor phrasing, I definitely didn't mean to imply that the recent PR introduced these issues, but rather that I had noticed them during my previous testing. Good to know the .md edge case isn't applicable to our setup, and I'm glad the hash routing was already properly addressed at the source in #26, Thanks for the clarification and for your patience. 🙏🤍 |
Closes: #3
Summary
This PR improve the type map generation :
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI
used ai for getting insight and discussion