fix(processor): resolve fragile md replacement and multi-hash URLs#27
Closed
moshams272 wants to merge 1 commit intowebpack:mainfrom
Closed
fix(processor): resolve fragile md replacement and multi-hash URLs#27moshams272 wants to merge 1 commit intowebpack:mainfrom
moshams272 wants to merge 1 commit intowebpack:mainfrom
Conversation
This patch builds on top of the recent type-map refactor to safely handle TypeDoc URL edge cases. It prevents broken links when filenames contain '.md' before the extension using a boundary regex, and extracts the final anchor when TypeDoc generates multiple hash fragments to ensure correct browser navigation.
Member
|
While I appreciate the intent here, we are trying to save the bulk of this work for GSoC. We got the fundamental workings down (basic pipeline), but a lot of the work here is for GSoC, which has not begun. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch builds on top of the recent type-map refactor to safely handle TypeDoc URL edge cases. It prevents broken links when filenames contain '.md' before the extension using a boundary regex, and extracts the final anchor when TypeDoc generates multiple hash fragments to ensure correct browser navigation.
Summary
Fixes two critical URL routing edge cases from the recent
type-maprefactor (#25):.mdreplacement: Uses/\.md($|#)/regex to avoid breaking paths containing.md(e.g.,utils.md5.md).#methods#name) to ensure correct browser anchoring.Follows up on issues raised in my previous PR fix(processor): resolve malformed URLs and incomplete type mapping #19.
What kind of change does this PR introduce?
Fix
Did you add tests for your changes?
No. Verified locally by running the doc generation successfully.
Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
N/A.
Use of AI
All code was reviewed and tested manually.