Skip to content

chore: format cuda code#6508

Merged
0ax1 merged 1 commit intodevelopfrom
ad/format-cuda-code
Feb 16, 2026
Merged

chore: format cuda code#6508
0ax1 merged 1 commit intodevelopfrom
ad/format-cuda-code

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Feb 13, 2026

What changes are included in this PR?

Formats all CUDA code. The clang-format style picked is identical to the style used for vortex-duckdb. Generated code is excluded.

What is the rationale for this change?

Consistent formatting for all CUDA code.

Are there any user-facing changes?

No

@0ax1 0ax1 force-pushed the ad/format-cuda-code branch from ab089ba to a858b2d Compare February 13, 2026 19:03
@0ax1 0ax1 added the changelog/chore A trivial change label Feb 13, 2026
@0ax1 0ax1 enabled auto-merge (squash) February 13, 2026 19:21
@0ax1 0ax1 requested a review from a10y February 13, 2026 19:21
@a10y
Copy link
Contributor

a10y commented Feb 13, 2026

should we have a check for this?

@a10y
Copy link
Contributor

a10y commented Feb 13, 2026

Or a way to plumb it into the normal formatters we run

@0ax1
Copy link
Contributor Author

0ax1 commented Feb 13, 2026

should we have a check for this?

Not sure i want to require everyone to have clang-format installed.

@0ax1
Copy link
Contributor Author

0ax1 commented Feb 13, 2026

Or a way to plumb it into the normal formatters we run

In some way, I'd love CI to just auto-format, re-stage and commit any touched file. Repeating CI runs bc of formatting seems a bit like a waste of time.

@0ax1 0ax1 marked this pull request as draft February 13, 2026 20:46
auto-merge was automatically disabled February 13, 2026 20:46

Pull request was converted to draft

@0ax1 0ax1 force-pushed the ad/format-cuda-code branch from a858b2d to 5d0f6e4 Compare February 16, 2026 11:46
@0ax1 0ax1 marked this pull request as ready for review February 16, 2026 11:46
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 force-pushed the ad/format-cuda-code branch from 5d0f6e4 to 4c043ce Compare February 16, 2026 11:48
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 16, 2026

Merging this PR will improve performance by 12.16%

⚡ 2 improved benchmarks
✅ 1133 untouched benchmarks
⏩ 1268 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation new_bp_prim_test_between[i16, 32768] 125.3 µs 113.7 µs +10.2%
Simulation old_bp_prim_test_between[i64, 32768] 555.7 µs 495.5 µs +12.16%

Comparing ad/format-cuda-code (4c043ce) with develop (cb42321)2

Open in CodSpeed

Footnotes

  1. 1268 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (873a7fb) during the generation of this report, so cb42321 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@0ax1 0ax1 enabled auto-merge (squash) February 16, 2026 11:56
@0ax1 0ax1 merged commit 4f8a984 into develop Feb 16, 2026
48 checks passed
@0ax1 0ax1 deleted the ad/format-cuda-code branch February 16, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants