Skip to content

feat: mask compute to lazy mask execution#6485

Open
joseph-isaacs wants to merge 12 commits intodevelopfrom
ji/mask-compute-fn-remove
Open

feat: mask compute to lazy mask execution#6485
joseph-isaacs wants to merge 12 commits intodevelopfrom
ji/mask-compute-fn-remove

Conversation

@joseph-isaacs
Copy link
Contributor

Does this PR closes an open issue or discussion?

  • Closes #.

What changes are included in this PR?

What is the rationale for this change?

How is this change tested?

Are there any user-facing changes?

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs changed the title wip feat: mask compute to lazy mask execution Feb 13, 2026
@joseph-isaacs joseph-isaacs added the changelog/feature A new feature label Feb 13, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 13, 2026

Merging this PR will degrade performance by 49.83%

⚡ 1 improved benchmark
❌ 16 regressed benchmarks
✅ 1118 untouched benchmarks
⏩ 1268 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bench_dict_mask[(0.9, 0.9)] 1.3 ms 2.4 ms -48.65%
Simulation bench_dict_mask[(0.01, 0.9)] 1.2 ms 2.4 ms -49.83%
Simulation bench_dict_mask[(0.1, 0.9)] 1.2 ms 2.3 ms -47.32%
Simulation bench_dict_mask[(0.1, 0.01)] 1.2 ms 2 ms -38.3%
Simulation bench_dict_mask[(0.01, 0.1)] 1.2 ms 2 ms -39.85%
Simulation bench_dict_mask[(0.5, 0.01)] 1.2 ms 1.8 ms -34.56%
Simulation bench_dict_mask[(0.01, 0.5)] 1.2 ms 2.1 ms -42.34%
Simulation bench_dict_mask[(0.9, 0.01)] 1.2 ms 2 ms -38.33%
Simulation bench_dict_mask[(0.5, 0.1)] 1.2 ms 1.9 ms -36.21%
Simulation bench_dict_mask[(0.5, 0.9)] 1.2 ms 2.3 ms -47.29%
Simulation bench_dict_mask[(0.5, 0.5)] 1.2 ms 2.1 ms -42.36%
Simulation bench_dict_mask[(0.9, 0.1)] 1.2 ms 2 ms -39.83%
Simulation bench_dict_mask[(0.1, 0.1)] 1.2 ms 2 ms -39.82%
Simulation bench_dict_mask[(0.01, 0.01)] 1.2 ms 2 ms -38.36%
Simulation bench_dict_mask[(0.9, 0.5)] 1.2 ms 2.1 ms -42.38%
Simulation bench_dict_mask[(0.1, 0.5)] 1.2 ms 2.1 ms -42.39%
Simulation patched_take_200k_dispersed 5.6 ms 5.1 ms +11.29%

Comparing ji/mask-compute-fn-remove (af76682) with develop (d9d75da)

Open in CodSpeed

Footnotes

  1. 1268 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment on lines +18 to +20
let Validity::Array(keep_mask) = validity else {
return Ok(None);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems weird

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this handles it in the outer fn, I guess we could panic here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would panic

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added the action/benchmark Trigger full benchmarks to run on this PR label Feb 13, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@robert3005
Copy link
Contributor

I think you also need to change benchmarks to recursively canonicalize

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs removed the action/benchmark Trigger full benchmarks to run on this PR label Feb 13, 2026
…-remove

# Conflicts:
#	encodings/alp/public-api.lock
#	encodings/bytebool/public-api.lock
#	encodings/datetime-parts/public-api.lock
#	encodings/decimal-byte-parts/public-api.lock
#	encodings/zigzag/public-api.lock
#	vortex-array/public-api.lock
#	vortex-array/src/compute/mod.rs
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs marked this pull request as ready for review February 13, 2026 17:22
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants