Skip to content

fix(core): avoid vite integration type conflicts with vite #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webfansplz merged 1 commit into from
May 2, 2026
+21 −5
Merged

fix(core): avoid vite integration type conflicts with vite #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/core/src/integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,16 @@
export { DevToolsIntegration, runDevTools } from './node/plugins/integration'
export type { DevToolsIntegrationOptions } from './node/plugins/integration'
import {
DevToolsIntegration as _DevToolsIntegration,
runDevTools as _runDevTools,
} from './node/plugins/integration'

export interface DevToolsIntegrationOptions {
config: unknown
}

export function DevToolsIntegration(options: DevToolsIntegrationOptions): { name: string } {
Comment thread
webfansplz marked this conversation as resolved.
return _DevToolsIntegration(options as Parameters<typeof _DevToolsIntegration>[0])
}

Comment thread
webfansplz marked this conversation as resolved.
export function runDevTools(builder: unknown): Promise<void> {
return _runDevTools(builder)
}
6 changes: 4 additions & 2 deletions test/__snapshots__/tsnapi/@vitejs/devtools/integration.snapshot.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@
*/
// #region Interfaces
export interface DevToolsIntegrationOptions {
config: ResolvedConfig;
config: unknown;
}
// #endregion

// #region Functions
export declare function DevToolsIntegration(_: DevToolsIntegrationOptions): Plugin;
export declare function DevToolsIntegration(_: DevToolsIntegrationOptions): {
name: string;
};
export declare function runDevTools(_: unknown): Promise<void>;
// #endregion
2 changes: 1 addition & 1 deletion test/__snapshots__/tsnapi/@vitejs/devtools/integration.snapshot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
*/
// #region Functions
export function DevToolsIntegration(_) {}
export async function runDevTools(_) {}
export function runDevTools(_) {}
// #endregion
Loading