Skip to content

fix(core): avoid vite integration type conflicts with vite#303

Merged
webfansplz merged 1 commit intomainfrom
fix/vite-integration-types
May 2, 2026
Merged

fix(core): avoid vite integration type conflicts with vite#303
webfansplz merged 1 commit intomainfrom
fix/vite-integration-types

Conversation

@webfansplz
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 2, 2026 14:37
@webfansplz webfansplz force-pushed the fix/vite-integration-types branch from aaa0973 to 87ca753 Compare May 2, 2026 14:40
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 2, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/devtools@303
npm i https://pkg.pr.new/@vitejs/devtools-kit@303
npm i https://pkg.pr.new/@vitejs/devtools-rolldown@303
npm i https://pkg.pr.new/@vitejs/devtools-self-inspect@303

commit: 13387b5

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the @vitejs/devtools/integration public entrypoint to avoid leaking Vite types (and related type conflicts) by wrapping the internal integration exports behind simplified, structurally-typed functions.

Changes:

  • Replaced direct re-exports of DevToolsIntegration / runDevTools with wrapper functions.
  • Hid Vite-specific types from the public API surface by using unknown/structural return typing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/core/src/integration.ts
Comment thread packages/core/src/integration.ts
@webfansplz webfansplz force-pushed the fix/vite-integration-types branch from 87ca753 to 13387b5 Compare May 2, 2026 14:51
@webfansplz webfansplz merged commit 960d055 into main May 2, 2026
9 checks passed
@webfansplz webfansplz deleted the fix/vite-integration-types branch May 2, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants