Skip to content

Fix manifest push failure handling #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbezak merged 1 commit into from
Mar 3, 2026
+10 −3
Merged

Fix manifest push failure handling #2193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions releasenotes/notes/multiarch-manifests-pipefail-9b860f83d0f93f1e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
fixes:
- |
Fixes CI multiarch manifest creation by setting ``pipefail`` in the
manifest script. Failures from ``docker manifest create`` or
``docker manifest push`` now fail the job even when piped to ``tee``.
7 changes: 4 additions & 3 deletions tools/multiarch-manifests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
#!/usr/bin/env bash
# Script used by the Image build workflow to build & push multiarch manifests.

set -ex
set -o errexit
set -o xtrace
set -o pipefail

mkdir -p logs
images=$(cat all-pushed-images.txt | sort | uniq)

# Filter out Ubuntu and Rocky Bifrost images
manifest_images=$(echo "$images" \
| grep -E '.*-(amd64|aarch64)$' \
| sed -E 's/-(amd64|aarch64)$//' \
| sed -nE 's/-(amd64|aarch64)$//p' \
| sort | uniq)

if [ -z "$manifest_images" ]; then
Expand Down
Loading