Fix manifest push failure handling#2193
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where CI jobs would not fail despite docker manifest commands failing. This is achieved by adding set -o pipefail to the shell script, ensuring that the exit code of a failed command in a pipeline is propagated. The change is effective. The included comment suggests a minor improvement for script robustness.
Signed-off-by: Bartosz Bezak <bartosz@stackhpc.com>
bbezak
force-pushed
the
multiarch-manifests-pipefail
branch
from
68f5f88 to
e22310d
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue in the multiarch manifest creation script where failures in piped commands were not causing the job to fail. The addition of set -o pipefail is the right solution. The change also includes a nice simplification, replacing a grep | sed pipeline with a single sed command. I have one minor suggestion to improve the conciseness of the script's option settings.
|
We need to backport this to Caracal right? |
3 participants
No description provided.