chore: bump Rust edition to 2024 and update dependencies + clippy#710
Open
Saul-STFC wants to merge 2 commits into
Open
chore: bump Rust edition to 2024 and update dependencies + clippy#710Saul-STFC wants to merge 2 commits into
Saul-STFC wants to merge 2 commits into
Conversation
…actors Upgrade workspace and crates to Rust 2024 edition and apply tool-driven fixes: - Bump Rust edition from 2021 to 2024 across workspace crates (Cargo.toml, Cargo.nix) - Update `rustls-webpki` dependency to 0.103.13 - Apply `cargo fix --edition` changes - Add `use<>` lifetime capture in `impl Trait` return types for iterators - Apply Clippy suggestions and minor refactors - Simplify iterator-returning functions with correct lifetime capture syntax - Refactor `trystream_any` to fix warning
Saul-STFC
force-pushed
the
rust-2024-upgrade
branch
from
ea1e686 to
fd0995b
Compare
17 tasks
sbernauer
reviewed
Jun 3, 2026
| while let Some(value) = stream.next().await { | ||
| if let Ok(true) | Err(_) = value { | ||
| return value; | ||
| loop { |
Member
There was a problem hiding this comment.
I personally found the existing code a bit easier to read to be honest.
But I let you decide if we want to keep it and silence clippy
Member
There was a problem hiding this comment.
In that case I suggest we slap a #[allow(clippy::xxx)] at the existing code and keep that
Member
There was a problem hiding this comment.
I have a bit of mixed feelings about touching rust/p12. As documented in rust/p12/README.md it's a fork of https://github.com/hjiayz/p12/. We can hopefully get rid of it eventually.
So it's nice to maintain it, on the other hand this increases the diff to upstream...
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Explicitly selecting TryFutureExt::into_future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade workspace and crates to Rust 2024 edition and apply tool-driven fixes:
rustls-webpkidependency to 0.103.13 to fix security vulnerability warningscargo fix --editionchangesuse<>lifetime capture inimpl Traitreturn types for iteratorstrystream_anyto fix warningPart of Bump our Rust code to 2024 edition issues#832
Description
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker