Skip to content

DF-23700 fix scale of latency for beholder + cleanups #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vlfig merged 1 commit into from
Apr 23, 2026
+13 −11
Merged

DF-23700 fix scale of latency for beholder + cleanups #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions metrics/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (

var (
RPCCallLatency = promauto.NewHistogramVec(prometheus.HistogramOpts{
Name: rpcCallLatencyBeholder,
Name: rpcCallLatencyMetricName,
Help: "The duration of an RPC call in nanoseconds",
Buckets: []float64{
float64(50 * time.Millisecond),
Expand All @@ -31,7 +31,7 @@ var (
}, []string{"chainFamily", "chainID", "rpcUrl", "isSendOnly", "success", "rpcCallName"})
)

const rpcCallLatencyBeholder = "rpc_call_latency"
const rpcCallLatencyMetricName = "rpc_call_latency"

// RPCClientMetrics records RPC call latency to Prometheus and Beholder (failures: success="false"; same pattern as multinode metrics).
// Construct once per chain (or process) with ChainFamily and ChainID; pass rpcUrl and isSendOnly on each call
Expand Down Expand Up @@ -59,7 +59,11 @@ type RPCClientMetricsConfig struct {

// NewRPCClientMetrics creates RPC client metrics that publish to Prometheus and Beholder.
func NewRPCClientMetrics(cfg RPCClientMetricsConfig) (RPCClientMetrics, error) {
latency, err := beholder.GetMeter().Float64Histogram(rpcCallLatencyBeholder)
latency, err := beholder.GetMeter().Float64Histogram(
rpcCallLatencyMetricName,
metric.WithUnit("ms"),
metric.WithDescription("The duration of an RPC call in milliseconds"),
)
if err != nil {
return nil, fmt.Errorf("failed to register RPC call latency metric: %w", err)
}
Expand All @@ -71,25 +75,23 @@ func NewRPCClientMetrics(cfg RPCClientMetricsConfig) (RPCClientMetrics, error) {
}

func (m *rpcClientMetrics) RecordRequest(ctx context.Context, rpcURL string, isSendOnly bool, callName string, latency time.Duration, err error) {
successStr := "true"
if err != nil {
successStr = "false"
}
successStr := strconv.FormatBool(err != nil)
sendStr := strconv.FormatBool(isSendOnly)
latencyNs := float64(latency)
safeRPCURL := SanitizeRPCURL(rpcURL)

RPCCallLatency.WithLabelValues(m.chainFamily, m.chainID, safeRPCURL, sendStr, successStr, callName).Observe(latencyNs)
RPCCallLatency.WithLabelValues(
m.chainFamily, m.chainID, safeRPCURL, sendStr, successStr, callName,
).Observe(latencyNs)

latAttrs := metric.WithAttributes(
m.latencyHis.Record(ctx, latencyNs/float64(time.Millisecond), metric.WithAttributes(
attribute.String("chainFamily", m.chainFamily),
attribute.String("chainID", m.chainID),
attribute.String("rpcUrl", safeRPCURL),
attribute.String("isSendOnly", sendStr),
attribute.String("success", successStr),
attribute.String("rpcCallName", callName),
)
m.latencyHis.Record(ctx, latencyNs, latAttrs)
))
}

// NoopRPCClientMetrics is a no-op implementation for when metrics are disabled.
Expand Down
Loading