DF-23700 fix scale of latency for beholder + cleanups#104
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
vlfig
force-pushed
the
fix-latency-scale
branch
from
7745fce to
e2b945d
Compare
ilija42
previously approved these changes
Apr 22, 2026
silaslenihan
previously approved these changes
Apr 22, 2026
Default buckets are good for milliseconds.
vlfig
force-pushed
the
fix-latency-scale
branch
from
5a9f3fb to
d8e99e9
Compare
Contributor
Author
|
Sorry, @ilija42 and @silaslenihan a conflict forced me to dismiss your reviews. |
ilija42
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Divides the latency
Durationvalue bytime.Millisecondsfor the beholder latency histogram.Cleans up implementation a bit.
Why
Metrics are coming in all in the "+Inf" bucket. All 13162 of them.
The default buckets, as used for the beholder histogram, are good for milliseconds so that's the idiom we're following.
Requires Dependencies
Resolves Dependencies