Skip to content

test(s3): cover delete bucket network fallback #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
overtrue wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −0
Open

test(s3): cover delete bucket network fallback #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions crates/s3/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3593,6 +3593,29 @@ mod tests {
}
}

#[tokio::test]
async fn delete_bucket_maps_other_failures_to_network() {
let response = http::Response::builder()
.status(500)
.header("x-amz-error-code", "InternalError")
.body(SdkBody::from(
r#"<?xml version="1.0" encoding="UTF-8"?>
<Error>
<Code>InternalError</Code>
<Message>Something went wrong.</Message>
</Error>"#,
))
.expect("build delete bucket response");
let (client, _request_receiver) = test_s3_client(Some(response));

let result = client.delete_bucket("bucket").await;

match result {
Err(Error::Network(message)) => assert!(message.contains("InternalError")),
other => panic!("Expected Network for delete bucket failure, got: {other:?}"),
}
}

#[tokio::test]
async fn delete_objects_with_force_delete_sets_rustfs_header() {
let response = http::Response::builder()
Expand Down