Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
This pull request adds focused regression coverage for the recent
delete_bucketerror mapping work in#163.Background
delete_bucket()now distinguishesNoSuchBucketandBucketNotEmptyfrom other backend failures. That behavior was covered for the two special-case branches, but the generic fallback path was still untested.Root Cause
The recent change introduced a third branch that maps all remaining SDK failures to
Error::Network. Without a direct test, later edits could accidentally change that fallback classification or stop surfacing the backend error code.Solution
Add one narrow unit test beside the existing
delete_bucketregression tests incrates/s3/src/client.rs. The new test drives a syntheticInternalErrorresponse and asserts that the client keeps classifying it asError::Networkwhile preserving the backend code in the message.Validation
I ran the focused seam first with
cargo test -p rc-s3 delete_bucket_maps_ --lib, then the full repository gate withmake pre-commit.