Print timing for page requests and re-parsing in server mode#1648
Merged
Print timing for page requests and re-parsing in server mode#1648
Conversation
Collaborator
|
🚀 Preview deployment available at: https://a66a98bf.rdoc-6cd.pages.dev (commit: be7f567) |
st0012
force-pushed
the
server-request-timing
branch
2 times, most recently
from
b511016 to
3eed0e3
Compare
The stats object created during initial parsing prints a progress bar with \r on a tty, which collides with the server's own stderr output. Set verbosity to 0 (quiet) since the server handles its own logging.
Log status, path, and duration for page requests only (not assets or status polls). Example: 200 /RDoc.html (12.3ms)
Show relative file paths and timing after re-parsing changed files. Example: Re-parsed lib/rdoc.rb (17.5ms)
The browser may close the connection before the server finishes writing (e.g. during live-reload navigation). This is harmless, so rescue it silently instead of printing a noisy thread backtrace.
st0012
force-pushed
the
server-request-timing
branch
from
3eed0e3 to
be7f567
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\ron a tty which collides with the server's own logging200 /RDoc.html (12.3ms)Re-parsed lib/rdoc.rb (17.5ms)