Fix server mode live reload for C files#1647
Merged
Conversation
The C parser didn't call `add_to_classes_or_modules` when creating classes/modules, so `clear_file_contributions` couldn't clean up old entries during server mode re-parse. This caused duplicate methods when editing C files with live reload. Add the call in both `find_class` and `handle_class_module`, matching what the Ruby parsers already do.
Collaborator
|
🚀 Preview deployment available at: https://9c73c44b.rdoc-6cd.pages.dev (commit: 1da15f9) |
Member
Author
|
Ah...I was trying to merge #1648 but clicked the merge button in the wrong tab 🤦♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_to_classes_or_moduleswhen creating classes/modules, soclear_file_contributionscouldn't clean up old entries during server mode re-parse — causing duplicate methods when editing C files with live reload.find_classandhandle_class_module, matching what the Ruby parsers already do.