Skip to content

Fix deprecation warnings and improve logging in tests #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emanlove merged 4 commits into from
Apr 8, 2026
+10 −6
Merged

Fix deprecation warnings and improve logging in tests #1974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d834e31
Fix deprecation warnings in unit tests and improve logging for approv…
yuriverweij Apr 7, 2026
10a27b8
Fix formatting issues in locator examples in PluginDocumentation
yuriverweij Apr 7, 2026
dc16969
Fix formatting issue in locator list creation in SeleniumLibrary
yuriverweij Apr 7, 2026
fa186e5
Merge branch 'master' into fix/unittest-fix-deprecation-and-improve-l…
emanlove Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/SeleniumLibrary/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ class SeleniumLibrary(DynamicCore):
| ${locator_list} = | `Create List` | css:div#div_id | xpath: //*[text(), " >> "] |
| `Page Should Contain Element` | ${locator_list} | | |
| ${element} = | Get WebElement | xpath: //*[text(), " >> "] | |
| ${locator_list} = | `Create List` | css:div#div_id | ${element } |
| ${locator_list} = | `Create List` | css:div#div_id | ${element} |
| `Page Should Contain Element` | ${locator_list} | | |
Chaining locators in new in SeleniumLibrary 5.0
Expand Down
2 changes: 1 addition & 1 deletion utest/test/api/approved_files/PluginDocumentation.test_many_plugins.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ List examples:
| ${locator_list} = | `Create List` | css:div#div_id | xpath: //*[text(), " >> "] |
| `Page Should Contain Element` | ${locator_list} | | |
| ${element} = | Get WebElement | xpath: //*[text(), " >> "] | |
| ${locator_list} = | `Create List` | css:div#div_id | ${element } |
| ${locator_list} = | `Create List` | css:div#div_id | ${element} |
| `Page Should Contain Element` | ${locator_list} | | |

Chaining locators in new in SeleniumLibrary 5.0
Expand Down
6 changes: 5 additions & 1 deletion utest/test/api/test_plugin_documentation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
import unittest

from approvaltests.approvals import verify
from approvaltests.reporters.first_working_reporter import FirstWorkingReporter
from approvaltests.reporters.generic_diff_reporter_factory import (
GenericDiffReporterFactory,
)
from approvaltests.reporters.python_native_reporter import PythonNativeReporter
from robot.utils import WINDOWS

from SeleniumLibrary import SeleniumLibrary
Expand All @@ -24,7 +26,9 @@ def setUp(self):
)
factory = GenericDiffReporterFactory()
factory.load(reporter_json)
self.reporter = factory.get_first_working()
self.reporter = FirstWorkingReporter(
factory.get_first_working(), PythonNativeReporter()
)

@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
def test_many_plugins(self):
Expand Down
6 changes: 3 additions & 3 deletions utest/test/keywords/test_browsermanagement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from mockito import when, mock, verify, verifyNoMoreInteractions, ANY
from mockito import when, mock, verify, ensureNoUnverifiedInteractions, ANY
from selenium import webdriver
from selenium.webdriver.chrome.service import Service as ChromeService
from selenium.webdriver.chrome.service import Service
Expand All @@ -21,8 +21,8 @@ def test_set_selenium_timeout_only_affects_open_browsers():
verify(second_browser).set_script_timeout(10.0)
ctx._drivers.active_drivers = []
bm.set_selenium_timeout("20 seconds")
verifyNoMoreInteractions(first_browser)
verifyNoMoreInteractions(second_browser)
ensureNoUnverifiedInteractions(first_browser)
ensureNoUnverifiedInteractions(second_browser)


def test_action_chain_delay_default():
Expand Down
Loading