Fix deprecation warnings and improve logging in tests#1974
Open
yuriverweij wants to merge 3 commits intorobotframework:masterfrom
Open
Fix deprecation warnings and improve logging in tests#1974yuriverweij wants to merge 3 commits intorobotframework:masterfrom
yuriverweij wants to merge 3 commits intorobotframework:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates test utilities and approval-test reporting to remove deprecation warnings and make failure reporting more robust.
Changes:
- Replaced deprecated
verifyNoMoreInteractionswithensureNoUnverifiedInteractionsin a browser management unit test. - Updated approval-test reporter selection to use
FirstWorkingReporterwith aPythonNativeReporterfallback. - Synced approval “golden” output and corrected a doc example typo/formatting in SeleniumLibrary’s documentation text.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| utest/test/keywords/test_browsermanagement.py | Removes deprecated Mockito API usage by switching to ensureNoUnverifiedInteractions. |
| utest/test/api/test_plugin_documentation.py | Wraps reporter selection with FirstWorkingReporter(..., PythonNativeReporter()) to improve failure reporting behavior. |
| utest/test/api/approved_files/PluginDocumentation.test_many_plugins.approved.txt | Updates approved output to match current generated plugin documentation formatting. |
| src/SeleniumLibrary/init.py | Fixes documentation table content (${element } → ${element}) so generated docs/approvals align. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing utility improvements:
verifyNoMoreInteractionswithensureNoUnverifiedInteractionsinutest/test/keywords/test_browsermanagement.pyas fix for deprecation.Test reporter enhancements:
utest/test/api/test_plugin_documentation.pyto useFirstWorkingReporterwith a fallback toPythonNativeReporter, to give better readable logging in pipeline runs.Now when a test fails in CI, instead of the
ReporterNotWorkingException, we get a full inline diff printed to log showing exactly what changed.FirstWorkingReporterwill try the GUI diff tool first (useful locally if Diffuse is installed), and fall back toPythonNativeReporter