Skip to content

fix(docker): don't leak FA Pro token into build logs #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanFlurry merged 1 commit into from
Jun 29, 2026
Merged

fix(docker): don't leak FA Pro token into build logs #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions website/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ RUN apk add --no-cache git && npm install -g pnpm@9
# in this discarded build stage — the final caddy image never contains it.
ARG DOCS_THEME_SHA=450c498555135098c6a927adfdf13458be9be22a
ARG FONTAWESOME_PACKAGE_TOKEN
RUN export FONTAWESOME_PACKAGE_TOKEN="$FONTAWESOME_PACKAGE_TOKEN" \
&& git clone https://github.com/rivet-dev/docs-theme.git /theme \
# The ARG is already in this RUN's environment, so the icons generate reads
# FONTAWESOME_PACKAGE_TOKEN directly — we don't echo it into the build log.
RUN git clone https://github.com/rivet-dev/docs-theme.git /theme \
&& git -C /theme checkout "$DOCS_THEME_SHA" \
&& pnpm -C /theme install \
&& pnpm -C /theme/packages/theme/vendor/icons run gen:manifest \
Expand Down
Loading