fix(docker): don't leak FA Pro token into build logs#149
Merged
Conversation
The ARG is already in the RUN environment, so the icons generate reads FONTAWESOME_PACKAGE_TOKEN directly instead of exporting it (which printed the token into Railway build logs). Build behaviour unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
railway-app
Bot
temporarily deployed
to
secure-exec / secure-exec-pr-149
railway-app
Bot
temporarily deployed
to
rivet-frontend / secure-exec-pr-149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as agentos: the website Dockerfile exported
FONTAWESOME_PACKAGE_TOKENin a RUN, printing the token into Railway build logs (and tripping BuildKitSecretsUsedInArgOrEnv). The ARG is already in the RUN env, so the icons generate reads it directly. Verified: Docker build passes (32 pages, image) with 0 token occurrences in the log.🤖 Generated with Claude Code