test(rivetkit-core): cover nested wait_until and keep_awake-during-grace#4835
Draft
NathanFlurry wants to merge 1 commit intodriver-tests-fixes/reject-non-request-actor-pathsfrom
Draft
Conversation
|
🚅 Deployed to the rivet-pr-4835 environment in rivet-frontend
|
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 28, 2026
Contributor
Preview packages published to npmInstall with: npm install rivetkit@pr-4835All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-1d9e1a8
docker pull rivetdev/engine:full-1d9e1a8Individual packagesnpm install rivetkit@pr-4835
npm install @rivetkit/react@pr-4835
npm install @rivetkit/rivetkit-napi@pr-4835
npm install @rivetkit/workflow-engine@pr-4835 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack Context
This stack fixes two actor sleep driver-test failures around shutdown-grace work and the deprecated
setPreventSleepfixture path.Why?
Nested
waitUntilwork can currently be refused while shutdown cleanup drains tracked tasks, which drops user work registered during the sleep grace window. This PR adds focusedrivetkit-corecoverage for nestedwait_untilduring teardown drain and for keep-awake work held by the on-sleep cleanup callback.Validation
cargo test -p rivetkit-core nested_wait_until_during_grace_is_drainedfails before the core fix, proving the teardown-drain bug.cargo test -p rivetkit-core keep_awake_in_on_sleep_blocks_finalize_until_releasedpasses and locks the keep-awake grace gate.