fix(rivetkit): retry connection when getParams throws#4823
Draft
NathanFlurry wants to merge 1 commit intomainfrom
Draft
fix(rivetkit): retry connection when getParams throws#4823NathanFlurry wants to merge 1 commit intomainfrom
NathanFlurry wants to merge 1 commit intomainfrom
Conversation
The retry classifier added in 41c83ab wraps unclassified errors in pRetry's AbortError, which silently broke the contract from the original getParams PR (#4473) that promised "errors from getParams allow the connection to retry." Adding client/get_params_failed to classifyActorError as reconnect_only restores that retry behavior so e.g. a JWT refresh that fails once will be retried on the next connection attempt. This restores the actor-conn test "should surface getParams errors and retry connection setup," which has been broken on main since 41c83ab.
|
🚅 Deployed to the rivet-pr-4823 environment in rivet-frontend
|
Member
Author
Contributor
Preview packages published to npmInstall with: npm install rivetkit@pr-4823All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-494dbbe
docker pull rivetdev/engine:full-494dbbeIndividual packagesnpm install rivetkit@pr-4823
npm install @rivetkit/react@pr-4823
npm install @rivetkit/rivetkit-napi@pr-4823
npm install @rivetkit/workflow-engine@pr-4823 |
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack Context
This stack collects fixes uncovered by methodically running the RivetKit driver test suite (
/driver-test-runner) one file group at a time. Each PR addresses a single failing test with a narrow root-cause fix.Why?
The original
getParamsPR (#4473) promised:The retry classifier added later in 41c83ab (
fix(rivetkit): add lifecycle error retry and gateway HTTP routing) wraps any error not recognized byclassifyActorErrorinpRetry'sAbortError, halting retries.client/get_params_failedwas never added to the classifier, silently breaking that contract.This adds the missing classifier arm so the connection-open path retries when
getParams()throws (e.g. a transient JWT refresh failure), restoring the documented behavior.Test impact
Restores the previously failing driver test:
The test has been broken on
mainsince 41c83ab (~2 weeks).