Retire report

[aaccensi]

Context

The visuals depicted in the scenario energy mix infographic and the texts and charts in the scenario report are outdated and can become confusing. They often fail to load when we change the modelling, and we only find out during deploy testing, which makes them even more of a burden.

Implemented changes

• etsource: Deleted all associated GQL queries and input files related to Energy mix infographic and Scenario report.
• etmodel: Removed the Energy mix infographic and replaced the Scenario report with a deprecation notice.
• etengine: Added a migration removing input_element_energy_mix_capacity_per_unit_wind_turbine_inland.
• documentation: Replaced energy mix factsheet section with a retirement notice.

Related

Closes quintel/etmodel#4651

This effort is composed of the following 4 PRs:

• etsource: Retire report #3425 [THIS ONE]
• etmodel: Retire energy mix entirely and replace scenario report by retire notice. etmodel#4668
• etengine: Migration to remove input only used in the Energy Mix infographic. etengine#1716
• documentation: Replace energy mix factsheet section with a retirement notice documentation#298

Checklist

• I have tested these changes
• I have updated documentation as needed
• I have tagged the relevant people for review

[kaskranenburgQ]

I see that some of the queries are still mentioned in the file ovm.yml on etmodel. Should this file be removed in the ETModel PR as well?

Other than that the removed queries are no longer referenced in both ETSource and ETModel.

[mabijkerk]

Good question @kaskranenburgQ, can you check this @aaccensi?

[aaccensi]

Good question @kaskranenburgQ, can you check this @aaccensi?

@mabijkerk This doesn't seems to be related to the task at hand. this file seem to be part of a broken feature that generated a CSV export for a saved scenario when those were still in etmodel. Likely broken since they were moved to my-etm.
If no one has complained about that since my-etm was created I imagine it can be removed, but not only that file, anything related to that feature/controller I guess:

To delete

File	Notes
app/controllers/saved_scenario_reports_controller.rb	The broken controller
app/views/saved_scenario_reports/show.csv.erb	CSV view template
app/services/fetch_api_scenario_queries.rb	Only used by this controller
spec/services/fetch_api_scenario_queries_spec.rb	Spec for the above service
config/saved_scenario_reports/ovm.yml	The only report config (delete dir too)

To change

File	Change
config/routes.rb:55	Remove get '/report/:report_name' => 'saved_scenario_reports#show'

Maybe to be taken up in a new cleanup task?

[mabijkerk]

Right, that's clear. Could you open an issue for it on etmodel for it @aaccensi? Then we'll pick that up separately as part of the clean up.