Skip to content

Jupyter: Acknowledge SIGINT without exiting #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgestagg merged 1 commit into from
Jul 2, 2026
Merged

Jupyter: Acknowledge SIGINT without exiting #498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions ggsql-jupyter/src/kernel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,17 +137,14 @@ impl KernelServer {
}
}
_ = tokio::signal::ctrl_c() => {
tracing::warn!("Received SIGINT, shutting down gracefully");
// Send a final idle status before exiting
// Note: We don't have a parent message here, so we'll send without one
let msg = self.create_message(
"status",
json!({"execution_state": "idle"}),
None,
);
let zmq_msg = self.serialize_message_with_topic(&msg, "status")?;
let _ = self.iopub.send(zmq_msg).await;
break;
// With `interrupt_mode: "signal"`, the frontend sends SIGINT to
// interrupt a running cell, not to stop the kernel. Emit a busy
// -> idle pair to acknowledge the interrupt.
// TODO: When cell execution becomes async, cancel any in-flight
// request here instead.
tracing::debug!("Received SIGINT; acknowledging.");
self.send_status_initial("busy").await?;
self.send_status_initial("idle").await?;
}
}
}
Expand Down
Loading