Jupyter: Acknowledge SIGINT without exiting#498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Jupyter kernel, we use
interrupt_mode: "signal", so the frontend sends SIGINT to interrupt a running cell, not to exit.Previously, we quit on SIGINT, leading to interrupts killing the kernel:
With this change we handle the SIGINT by immediately acknowledging we are idle and then continue running, so sending Ctrl-C in Positron acts as expected.
Shutting down and restarting the kernel still works, because that uses a different mechanism.
In the future, we will likely switch to asynchronous cell execution. At that point we should cancel any in-flight async requests before acknowledging we are idle.