Skip to content

i18n(ja): use English for config category headings and TiDB Cloud Clinic#23159

Merged
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-config-category-names
Jun 29, 2026
Merged

i18n(ja): use English for config category headings and TiDB Cloud Clinic#23159
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-config-category-names

Conversation

@yahonda

@yahonda yahonda commented Jun 29, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fix two issues:

  1. Configuration category headings in English (tidb-configuration-file.md)

    Config category names (like performance, log, security) are configuration key prefixes, not prose descriptions. They should be in English to match the actual config file syntax. Fixed 10 headings:

    • パフォーマンスperformance
    • ログlog
    • ログファイルlog.file
    • 安全security
    • オープントレースopentracing
    • トランザクションローカルラッチtxn-local-latches
    • 状態status
    • 分離読み取りisolation-read
    • 実例instance
    • プロキシプロトコルproxy-protocol
    • 実験的experimental
  2. TiDB Cloudクリニック → TiDB Cloud Clinic (3 files, 8 occurrences)

    "Clinic" is a proper service name and should be in English. Affected files: TOC-tidb-cloud.md, tidb-cloud/tidb-cloud-clinic.md, tidb-cloud/releases/tidb-cloud-release-notes.md.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 29, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiancai for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the terminology "TiDB Cloud Clinic" in the Japanese documentation and updates several configuration headings in tidb-configuration-file.md from Japanese translations to their English parameter names (e.g., changing "ログ" to "log"). Feedback was provided to adjust the heading level of log.file to ### to maintain a proper heading hierarchy and prevent jumping directly to level 4 subheadings.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tidb-configuration-file.md Outdated
@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 29, 2026
@yahonda yahonda force-pushed the i18n-ja-fix-config-category-names branch from 7eee79d to 2ebc42f Compare June 29, 2026 04:51
@ti-chi-bot ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 29, 2026
@yahonda yahonda force-pushed the i18n-ja-fix-config-category-names branch from c28a133 to d7980e1 Compare June 29, 2026 06:31
yahonda added a commit to yahonda/docs that referenced this pull request Jun 29, 2026
These changes belong in PR pingcap#23159 (i18n-ja-fix-config-category-names)
which already includes:
- TiDB Cloud Clinic (PingCAP クリニック → PingCAP Clinic)
- Connected Care (コネクテッドケア → Connected Care)
- Config category heading translations
- TOC entries with the same Clinic/Connected Care changes

This PR (pingcap#23145) is now scoped to SQL and programming type names only.
@qiancai qiancai added the translation/no-need No need to translate this PR. label Jun 29, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Jun 29, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 29, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-06-29 10:44:31.141480492 +0000 UTC m=+36212.841859895: ☑️ agreed by qiancai.

@qiancai qiancai merged commit 48baf10 into pingcap:i18n-ja-release-8.5 Jun 29, 2026
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants