Skip to content

fix(ChatBot): Remove custom font size #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccaalpert wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ChatBot): Remove custom font size #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1db63a8
fix(ChatBot): Remove custom font size
rebeccaalpert Jun 30, 2026
30ed4a9
Address feedback
rebeccaalpert Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/module/src/Chatbot/Chatbot.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
);
border-radius: var(--pf-t--global--border--radius--medium);
box-shadow: var(--pf-t--global--box-shadow--lg);
font-size: var(--pf-t--global--font--size--md);
z-index: var(--pf-t--global--z-index--md);
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
Expand Down Expand Up @@ -162,9 +161,3 @@
}
}

// ============================================================================
// Information density styles
// ============================================================================
.pf-chatbot.pf-m-compact {
font-size: var(--pf-t--global--font--size--sm);
}
2 changes: 1 addition & 1 deletion packages/module/src/ChatbotConversationHistoryNav/ChatbotConversationHistoryNav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@

// Drawer menu
// ----------------------------------------------------------------------------
.pf-v6-c-menu {
.pf-v6-c-menu.pf-chatbot__history-menu {
--pf-v6-c-menu--PaddingBlockStart: 0;
--pf-v6-c-menu--BackgroundColor: var(--pf-t--global--background--color--floating--default);
// override high contrast style
Expand Down
8 changes: 7 additions & 1 deletion packages/module/src/ChatbotConversationHistoryNav/ChatbotConversationHistoryNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,13 @@ export const ChatbotConversationHistoryNav: FunctionComponent<ChatbotConversatio
return <HistoryEmptyState {...noResultsState} />;
}
return (
<Menu isPlain onSelect={onSelectActiveItem} activeItemId={activeItemId} {...menuProps}>
<Menu
className="pf-chatbot__history-menu"
isPlain
onSelect={onSelectActiveItem}
activeItemId={activeItemId}
{...menuProps}
>
<MenuContent {...menuContentProps}>{buildConversations()}</MenuContent>
</Menu>
);
Expand Down
1 change: 1 addition & 0 deletions packages/module/src/ChatbotHeader/ChatbotHeader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
display: grid;
}
.pf-chatbot__header {
font-size: var(--pf-t--global--font--size--md);

@mcoker mcoker Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will reintroduce the original bug where the title in the menu is too big since the menu is rendered in .pf-chatbot__header (in .pf-chatbot__actions).

Image

Looks like there is a ChatbotHeaderTitle component that the other examples use for the title/image. The comparing chatbots example isn't using it - the text is passed directly to ChatbotHeaderMain

chatbot/packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/EmbeddedComparisonChatbot.tsx

Line 118 in 9f1486e

<ChatbotHeaderMain>{name}</ChatbotHeaderMain>

According to the chatbot header docs it says to put your title in ChatbotHeaderTitle - can that be considered the right way of doing it and we update .pf-chatbot__title to be 16px, then just update the comparing chatbots example to use ChatbotHeaderTitle?

I don't think anyone would want to put the text directly in ChatbotHeaderMain as it's done in that example anyways. .pf-chatbot__header-main is a flex layout, so it's going to treat whatever is in it as flex children. So if you had text like chat<span>BOT</span> as the title, it would put a gap between "chat" and "BOT" since each node is treated as a flex item.

display: grid;
grid-template-columns: 1fr auto;
gap: var(--pf-t--global--spacer--sm);
Expand Down
Loading