fix(ChatBot): Remove custom font size#857
Conversation
Use PatternFly default of 14px rather than 16px.
|
Preview: https://chatbot-pr-chatbot-857.surge.sh A11y report: https://chatbot-pr-chatbot-857-a11y.surge.sh |
|
The only spot I'm seeing a regression is on https://chatbot-pr-chatbot-857.surge.sh/extensions/chatbot/overview/demo/comparing-chatbots/. The text in |
f8f4e3a to
30ed4a9
Compare
|
I just updated it @mcoker! |
| display: grid; | ||
| } | ||
| .pf-chatbot__header { | ||
| font-size: var(--pf-t--global--font--size--md); |
There was a problem hiding this comment.
This will reintroduce the original bug where the title in the menu is too big since the menu is rendered in .pf-chatbot__header (in .pf-chatbot__actions).
Looks like there is a ChatbotHeaderTitle component that the other examples use for the title/image. The comparing chatbots example isn't using it - the text is passed directly to ChatbotHeaderMain
According to the chatbot header docs it says to put your title in ChatbotHeaderTitle - can that be considered the right way of doing it and we update .pf-chatbot__title to be 16px, then just update the comparing chatbots example to use ChatbotHeaderTitle?
I don't think anyone would want to put the text directly in ChatbotHeaderMain as it's done in that example anyways. .pf-chatbot__header-main is a flex layout, so it's going to treat whatever is in it as flex children. So if you had text like chat<span>BOT</span> as the title, it would put a gap between "chat" and "BOT" since each node is treated as a flex item.
Use PatternFly default of 14px rather than 16px.
Fixes #853.
I did notice these arrows seem funky