Skip to content

fix(ChatBot): Remove custom font size#857

Open
rebeccaalpert wants to merge 2 commits into
patternfly:mainfrom
rebeccaalpert:display-mode-menu
Open

fix(ChatBot): Remove custom font size#857
rebeccaalpert wants to merge 2 commits into
patternfly:mainfrom
rebeccaalpert:display-mode-menu

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jul 1, 2026

Copy link
Copy Markdown
Member

Use PatternFly default of 14px rather than 16px.

Fixes #853.

I did notice these arrows seem funky

Ours Main Site
Screenshot 2026-07-01 at 1 55 15 PM Screenshot 2026-07-01 at 1 55 19 PM

Use PatternFly default of 14px rather than 16px.
@patternfly-build

patternfly-build commented Jul 1, 2026

Copy link
Copy Markdown

@rebeccaalpert rebeccaalpert marked this pull request as ready for review July 1, 2026 18:04
@mcoker

mcoker commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The only spot I'm seeing a regression is on https://chatbot-pr-chatbot-857.surge.sh/extensions/chatbot/overview/demo/comparing-chatbots/. The text in .pf-chatbot__header-main was 16px and now it's 14px.

@rebeccaalpert

Copy link
Copy Markdown
Member Author

I just updated it @mcoker!

display: grid;
}
.pf-chatbot__header {
font-size: var(--pf-t--global--font--size--md);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will reintroduce the original bug where the title in the menu is too big since the menu is rendered in .pf-chatbot__header (in .pf-chatbot__actions).

Image

Looks like there is a ChatbotHeaderTitle component that the other examples use for the title/image. The comparing chatbots example isn't using it - the text is passed directly to ChatbotHeaderMain

According to the chatbot header docs it says to put your title in ChatbotHeaderTitle - can that be considered the right way of doing it and we update .pf-chatbot__title to be 16px, then just update the comparing chatbots example to use ChatbotHeaderTitle?

I don't think anyone would want to put the text directly in ChatbotHeaderMain as it's done in that example anyways. .pf-chatbot__header-main is a flex layout, so it's going to treat whatever is in it as flex children. So if you had text like chat<span>BOT</span> as the title, it would put a gap between "chat" and "BOT" since each node is treated as a flex item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] - [Display mode menu looks broken]

3 participants