Skip to content

fix: normalize leading question marks in exposed port queries #3424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 1 commit into from
May 16, 2026
Merged

fix: normalize leading question marks in exposed port queries #3424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/agents/sandbox/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,5 +181,8 @@ def url_for(self, scheme: str) -> str:
base = f"{prefix}://{host}:{self.port}/"

if self.query:
return f"{base}?{self.query}"
query = self.query[1:] if self.query.startswith("?") else self.query
if query:
return f"{base}?{query}"

return base
12 changes: 12 additions & 0 deletions tests/sandbox/test_exposed_ports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,18 @@ def test_exposed_port_endpoint_with_query() -> None:
assert endpoint.url_for("ws") == "wss://preview.example.com/?bl_preview_token=abc123"


def test_exposed_port_endpoint_accepts_leading_question_mark_query() -> None:
endpoint = ExposedPortEndpoint(
host="preview.example.com",
port=443,
tls=True,
query="?bl_preview_token=abc123",
)

assert endpoint.url_for("http") == "https://preview.example.com/?bl_preview_token=abc123"
assert endpoint.url_for("ws") == "wss://preview.example.com/?bl_preview_token=abc123"


def test_exposed_port_endpoint_empty_query() -> None:
endpoint = ExposedPortEndpoint(host="127.0.0.1", port=8080, tls=False, query="")
assert endpoint.url_for("http") == "http://127.0.0.1:8080/"
Expand Down
Loading