fix: normalize leading question marks in exposed port queries#3424
Merged
seratch merged 1 commit intoMay 16, 2026
Merged
Conversation
Normalize exposed-port query values that already include a leading question mark so generated HTTP and WebSocket URLs do not contain a double question mark.
matthewflint
force-pushed
the
mflint/sandbox-normalize-port-query
branch
from
e2ab22e to
2d77938
Compare
seratch
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExposedPortEndpoint.querywhen it already starts with?.Why
url_for()currently always formats?{self.query}. That works whenquery="token=...", but produces??token=...when a provider passes the query in URL-component form (query="?token=..."). Normalizing this in one place makes provider implementations less fragile.Testing
uv run pytest tests/sandbox/test_exposed_ports.pyuv run ruff check src/agents/sandbox tests/sandboxuv run pyright