Skip to content

fix(i18n): added remaining missing French translations#1902

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
benwiacek:main
Mar 3, 2026
Merged

fix(i18n): added remaining missing French translations#1902
danielroe merged 2 commits intonpmx-dev:mainfrom
benwiacek:main

Conversation

@benwiacek
Copy link
Contributor

🔗 Linked issue

n/a

🧭 Context

n/a

📚 Description

Settings on https://npmx.dev/settings flagged there were 10 missing translations in French, so added them to fr-FR.json.

benwiacek and others added 2 commits March 3, 2026 12:40
@vercel
Copy link

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Mar 3, 2026 5:50pm
npmx.dev (canary) Ready Ready Preview, Comment Mar 3, 2026 5:50pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Mar 3, 2026 5:50pm

Request Review

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/fr-FR.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@benwiacek benwiacek changed the title Fix (i18n): Added remaining missing French translations fix (i18n): Added remaining missing French translations Mar 3, 2026
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

📝 Walkthrough

Walkthrough

This pull request adds new French localization entries to the i18n/locales/fr-FR.json file. The changes include a new footer key for "builders_chat", multiple shortcut-related keys for instant search functionality (including state labels and action descriptions), and a new community builders section under the about/get involved structure with title, description, and call-to-action copy. All changes are additive to the existing translation structure.

Possibly related PRs

Suggested reviewers

  • graphieros
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining that French translations were added to fr-FR.json to address missing translations flagged in settings.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6517eb2 and 6ca527d.

📒 Files selected for processing (1)
  • i18n/locales/fr-FR.json

Comment on lines +69 to +74
"instant_search": "Recherche instantanée",
"instant_search_on": "activée",
"instant_search_off": "désactivée",
"instant_search_turn_on": "activer",
"instant_search_turn_off": "désactiver",
"instant_search_advisory": "{label} {state} — {action}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Move instant_search* keys to the shortcuts namespace.

Lines 69-74 are currently nested under search, but these keys read like shortcuts.*. If the app resolves shortcuts.instant_search*, this change will not fix the missing-translation paths.

Proposed fix
   "shortcuts": {
     "section": {
       "global": "Général",
       "search": "Recherche",
       "package": "Paquet"
     },
     "focus_search": "Aller à la recherche",
     "show_kbd_hints": "Afficher les raccourcis clavier",
     "settings": "Ouvrir les paramètres",
     "compare": "Ouvrir la comparaison",
     "compare_from_package": "Ouvrir la comparaison (pré-rempli avec le paquet actuel)",
     "navigate_results": "Parcourir les résultats",
     "go_to_result": "Aller au résultat",
     "open_code_view": "Ouvrir la vue code",
     "open_docs": "Ouvrir la doc",
+    "instant_search": "Recherche instantanée",
+    "instant_search_on": "activée",
+    "instant_search_off": "désactivée",
+    "instant_search_turn_on": "activer",
+    "instant_search_turn_off": "désactiver",
+    "instant_search_advisory": "{label} {state} — {action}",
     "disable_shortcuts": "Vous pouvez désactiver les raccourcis clavier dans {settings}."
   },
   "search": {
@@
     "suggestion": {
       "user": "utilisateur",
       "org": "organisation",
       "view_user_packages": "Voir les paquets de cet utilisateur",
       "view_org_packages": "Voir les paquets de cette organisation"
-    },
-    "instant_search": "Recherche instantanée",
-    "instant_search_on": "activée",
-    "instant_search_off": "désactivée",
-    "instant_search_turn_on": "activer",
-    "instant_search_turn_off": "désactiver",
-    "instant_search_advisory": "{label} {state} — {action}"
+    }
   },

@benwiacek benwiacek changed the title fix (i18n): Added remaining missing French translations fix(i18n): Added remaining missing French translations Mar 3, 2026
@benwiacek benwiacek changed the title fix(i18n): Added remaining missing French translations fix(i18n): added remaining missing French translations Mar 3, 2026
@danielroe danielroe added this pull request to the merge queue Mar 3, 2026
Merged via the queue into npmx-dev:main with commit c3b0787 Mar 3, 2026
19 of 22 checks passed
@github-actions github-actions bot mentioned this pull request Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Thanks for your first contribution, @benwiacek! 💫

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants