Skip to content

fix(i18n): add all missing translations for German#1886

Merged
danielroe merged 6 commits intonpmx-dev:mainfrom
ameetmadan:patch-2
Mar 3, 2026
Merged

fix(i18n): add all missing translations for German#1886
danielroe merged 6 commits intonpmx-dev:mainfrom
ameetmadan:patch-2

Conversation

@ameetmadan
Copy link
Contributor

📚 Description

  • Add missing translations

@vercel
Copy link

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 3, 2026 5:26pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 3, 2026 5:26pm
npmx-lunaria Ignored Ignored Mar 3, 2026 5:26pm

Request Review

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/de-DE.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98c0339 and dc7c5d7.

📒 Files selected for processing (1)
  • i18n/locales/de-DE.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • i18n/locales/de-DE.json

📝 Walkthrough

Walkthrough

This PR updates the German locale file i18n/locales/de-DE.json, adding multiple new top-level sections (error, profile, blog, pds) and new footer keys (footer.blog, footer.builders_chat). It expands keyboard shortcut entries with instant_search-related keys, adds many UI translation keys (profile invitations, blog/draft/author states, Bluesky/atproto strings, trends/downloads options, compare/file_diff/header text), and includes minor phrasing and punctuation adjustments to existing entries.

Possibly related PRs

Suggested reviewers

  • trueberryless
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly relates to the changeset, which adds missing German translations to the i18n/locales/de-DE.json file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64a3cf2 and d02725b.

📒 Files selected for processing (1)
  • i18n/locales/de-DE.json

ameetmadan and others added 2 commits March 3, 2026 14:48
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
i18n/locales/de-DE.json (1)

1061-1061: ⚠️ Potential issue | 🔴 Critical

Fix invalid JSON string quoting in compare.no_dependency.add_column.

Line 1061 uses an unescaped ASCII quote inside the value, which terminates the string early and breaks JSON parsing (matching CI and Biome errors).
Use matching German quotes inside the JSON string.

💡 Proposed fix
-      "add_column": "Spalte „Keine Abhängigkeit" zum Vergleich hinzufügen"
+      "add_column": "Spalte „Keine Abhängigkeit“ zum Vergleich hinzufügen"
#!/bin/bash
# Verify JSON syntax for the locale file (read-only)
python - <<'PY'
import json, pathlib, sys
p = pathlib.Path("i18n/locales/de-DE.json")
try:
    json.loads(p.read_text(encoding="utf-8"))
    print("OK: valid JSON")
except json.JSONDecodeError as e:
    print(f"ERROR: {e.msg} at line {e.lineno}, column {e.colno}")
    sys.exit(1)
PY

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d02725b and 98c0339.

📒 Files selected for processing (1)
  • i18n/locales/de-DE.json

@danielroe danielroe added this pull request to the merge queue Mar 3, 2026
Merged via the queue into npmx-dev:main with commit 48eca97 Mar 3, 2026
20 checks passed
@github-actions github-actions bot mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants