Skip to content

feat: code preview page add scroll to top button #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 3 commits into from
Feb 27, 2026
+30 −5
Merged

feat: code preview page add scroll to top button #1686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d64a7fd
feat: code preview page add scroll to top button
btea Feb 27, 2026
edea541
feat: apply review
btea Feb 27, 2026
3dcf047
fix: revert
btea Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions app/pages/package-code/[[org]]/[packageName]/v/[version]/[...filePath].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,14 @@ function copyPermalinkUrl() {
copyPermalink(url.toString())
}

// Scroll to top of file content
const contentContainer = useTemplateRef('contentContainer')
function scrollToTop() {
if (contentContainer.value) {
contentContainer.value.scrollTo({ top: 0, behavior: 'smooth' })
}
}

// Canonical URL for this code page
const canonicalUrl = computed(() => `https://npmx.dev${getCodeUrl(route.params)}`)

Expand Down Expand Up @@ -410,6 +418,7 @@ defineOgImageComponent('Default', {
<!-- File content / Directory listing - sticky with internal scroll on desktop -->
<div
class="flex-1 min-w-0 overflow-x-hidden sticky top-28 self-start h-[calc(100vh-7rem)] overflow-y-auto"
ref="contentContainer"
>
<!-- File viewer -->
<template v-if="isViewingFile && fileContent">
Expand Down Expand Up @@ -449,6 +458,14 @@ defineOgImageComponent('Default', {
</div>
</div>
<div class="flex items-center gap-2">
<button
type="button"
class="px-2 py-1 font-mono text-xs text-fg-muted bg-bg-subtle border border-border rounded hover:text-fg hover:border-border-hover transition-colors items-center inline-flex gap-1"
@click="scrollToTop"
>
<span class="i-lucide:arrow-up w-3 h-3" />
{{ $t('code.scroll_to_top') }}
</button>
<button
v-if="selectedLines"
type="button"
Expand Down
3 changes: 2 additions & 1 deletion i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,8 @@
"preview": "preview",
"code": "code"
},
"file_path": "File path"
"file_path": "File path",
"scroll_to_top": "Scroll to top"
},
"badges": {
"provenance": {
Expand Down
3 changes: 2 additions & 1 deletion i18n/locales/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,8 @@
"preview": "预览",
"code": "代码"
},
"file_path": "文件路径"
"file_path": "文件路径",
"scroll_to_top": "滚动到顶部"
},
"badges": {
"provenance": {
Expand Down
3 changes: 3 additions & 0 deletions i18n/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2103,6 +2103,9 @@
},
"file_path": {
"type": "string"
},
"scroll_to_top": {
"type": "string"
}
},
"additionalProperties": false
Expand Down
3 changes: 2 additions & 1 deletion lunaria/files/en-GB.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,8 @@
"preview": "preview",
"code": "code"
},
"file_path": "File path"
"file_path": "File path",
"scroll_to_top": "Scroll to top"
},
"badges": {
"provenance": {
Expand Down
3 changes: 2 additions & 1 deletion lunaria/files/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,8 @@
"preview": "preview",
"code": "code"
},
"file_path": "File path"
"file_path": "File path",
"scroll_to_top": "Scroll to top"
},
"badges": {
"provenance": {
Expand Down
3 changes: 2 additions & 1 deletion lunaria/files/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,8 @@
"preview": "预览",
"code": "代码"
},
"file_path": "文件路径"
"file_path": "文件路径",
"scroll_to_top": "滚动到顶部"
},
"badges": {
"provenance": {
Expand Down
Loading