feat: code preview page add scroll to top button#1686
feat: code preview page add scroll to top button#1686danielroe merged 3 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a scroll-to-top feature to the package code viewer page: a Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
app/pages/package-code/[[org]]/[packageName]/v/[version]/[...filePath].vuei18n/locales/en.jsoni18n/locales/zh-CN.jsoni18n/schema.jsonlunaria/files/en-GB.jsonlunaria/files/en-US.jsonlunaria/files/zh-CN.json
app/pages/package-code/[[org]]/[packageName]/v/[version]/[...filePath].vue
Show resolved
Hide resolved
|
Hi @btea , I think we no longer need to implement the |
|
Thank you for reviewing. However, that function is for window page scrolling, which is not suitable for this scenario. |
|
Sorry, I overlooked that detail. Confirmed it's meant for window scrolling/touch devices and doesn't fit here. My mistake! |
🔗 Linked issue
/
🧭 Context
When previewing code, some files contain a lot of code. Scrolling back to the top of the code after scrolling through a lot of content can be time-consuming.
Adding a keyboard shortcut button to scroll to the top of the code would be much more convenient. Refer to the implementation on the GitHub page.
📚 Description