-
-
Notifications
You must be signed in to change notification settings - Fork 35.2k
child_process: watch child_process stdin pipe peer close event #62353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tseian
wants to merge
6
commits into
nodejs:main
Choose a base branch
from
Tseian:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+164
−9
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0b741f4
child_process: watch child_process stdin pipe peer close event
Tseian dc21154
child_process: expose a single function with a single bool argument
Tseian ce416a2
Refactor peer close handling in PipeWrap
Tseian 554052d
Merge branch 'nodejs:main' into main
Tseian ba77b4e
Refactor delete peer_close_watching_, try_catch, add kPeerCloseCallba…
Tseian 1a34143
format cpp
Tseian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| 'use strict'; | ||
|
|
||
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
| const { spawn } = require('child_process'); | ||
|
|
||
| if (common.isWindows) { | ||
| common.skip('Not applicable on Windows'); | ||
| } | ||
|
|
||
| const child = spawn(process.execPath, [ | ||
| '-e', | ||
| 'require("fs").closeSync(0); setTimeout(() => {}, 2000)', | ||
| ], { stdio: ['pipe', 'ignore', 'ignore'] }); | ||
|
|
||
| const timeout = setTimeout(() => { | ||
| assert.fail('stdin close event was not emitted'); | ||
| }, 1000); | ||
|
|
||
| child.stdin.on('close', common.mustCall(() => { | ||
| clearTimeout(timeout); | ||
| child.kill(); | ||
| })); | ||
|
|
||
| child.on('exit', common.mustCall(() => { | ||
| clearTimeout(timeout); | ||
| })); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite a bit of extra code, but wouldn't just adding an unconditional
sock.resume();give the same result? That way we keep reading (but not consuming) data from the socket until we hit EOF, and sinceallowHalfOpenisn't set, that should also close the writable side of the stream. In other words, if I'm not missing anything (and which is completely possible), this PR can be shortened to:(plus a comment or so about 'why' we do that, ofc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken, I should have tried using
socket.resume()as oyyd said but it does not work.I'll try it again.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@addaleax Indeed, It does not work. Is there something wrong?
changed
##pipe_peer_close.js
result