child_process: watch child_process stdin pipe peer close event

[Tseian]

Issue

#25131

Description

Watch pipe peer close(EOF/HUP) event, only support for unix. Once the event is detected, a JS callback is triggered to execute, which in turn triggers a method to destroy the socket. Eventually child_process.stdin.on('close') will be triggered.

Before

child_process.stdin.on('close') will not be triggered if the readable end of the pipe has been closed.

After

child_process.stdin.on('close') will be triggered if the readable end of the pipe has been closed.

Changes

• lib/internal/child_process.js
• src/pipe_wrap.cc
• src/pipe_wrap.h

Test

• test-child-process-stdin-close-event.js

[codecov]

Codecov Report

❌ Patch coverage is 72.72727% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.68%. Comparing base (2263b4d) to head (554052d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/pipe_wrap.cc	69.64%	5 Missing and 12 partials ⚠️
lib/internal/child_process.js	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62353      +/-   ##
==========================================
- Coverage   89.68%   89.68%   -0.01%     
==========================================
  Files         676      676              
  Lines      206710   206772      +62     
  Branches    39584    39609      +25     
==========================================
+ Hits       185398   185438      +40     
- Misses      13441    13444       +3     
- Partials     7871     7890      +19     

Files with missing lines	Coverage Δ
src/pipe_wrap.h	100.00% <ø> (ø)
lib/internal/child_process.js	94.69% <90.00%> (+0.03%)	⬆️
src/pipe_wrap.cc	77.52% <69.64%> (-3.78%)	⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Tseian]

@nodejs-github-bot retest

[Tseian]

@jasnell @ronag @jbunton-atlassian Hi everyone, Could you please have a code review for this PR?

[jasnell]

Is the err return value actually used on the JavaScript side? If it is, I'm not seeing where.

[Tseian]

Indeed, it's not currently used in the JS side. Do you mean that if it's not used in the JS side, we shouldn't return a value?

I saw that Bind and Connect both return values, and I assumed this was a convention.

[Tseian]

It no longer returns value.