Skip to content

refactor: DRY identity events #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmi22186 merged 2 commits into from
Apr 16, 2026
Merged

refactor: DRY identity events #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80a12f2
refactor: Reduce duplication of identity events
jamesnrokt Apr 15, 2026
3821519
chore: merge development and resolve identity event type conflict
jamesnrokt Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions src/Rokt-Kit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,33 +1104,28 @@ class RoktKit implements KitInterface {
return 'Successfully removed user attribute for forwarder: ' + name;
}

public onUserIdentified(user: IMParticleUser): string {
private handleIdentityComplete(user: IMParticleUser, eventType: RoktIdentityEventType, callbackName: string): string {
const filteredUser = user as FilteredUser;
this.filters.filteredUser = filteredUser;
this.userAttributes = user.getAllUserAttributes();
this.pendingIdentityEvents.push(this.buildIdentityEvent(ROKT_IDENTITY_EVENT_TYPE.IDENTIFY, filteredUser));
return 'Successfully called onUserIdentified for forwarder: ' + name;
this.pendingIdentityEvents.push(this.buildIdentityEvent(eventType, filteredUser));
return 'Successfully called ' + callbackName + ' for forwarder: ' + name;
}

public onUserIdentified(user: IMParticleUser): string {
this.filters.filteredUser = user as FilteredUser;
return this.handleIdentityComplete(user, ROKT_IDENTITY_EVENT_TYPE.IDENTIFY, 'onUserIdentified');
}

public onLoginComplete(user: IMParticleUser, _filteredIdentityRequest: unknown): string {
const filteredUser = user as FilteredUser;
this.userAttributes = user.getAllUserAttributes();
this.pendingIdentityEvents.push(this.buildIdentityEvent(ROKT_IDENTITY_EVENT_TYPE.LOGIN, filteredUser));
return 'Successfully called onLoginComplete for forwarder: ' + name;
return this.handleIdentityComplete(user, ROKT_IDENTITY_EVENT_TYPE.LOGIN, 'onLoginComplete');
}

public onLogoutComplete(user: IMParticleUser, _filteredIdentityRequest: unknown): string {
const filteredUser = user as FilteredUser;
this.userAttributes = user.getAllUserAttributes();
this.pendingIdentityEvents.push(this.buildIdentityEvent(ROKT_IDENTITY_EVENT_TYPE.LOGOUT, filteredUser));
return 'Successfully called onLogoutComplete for forwarder: ' + name;
return this.handleIdentityComplete(user, ROKT_IDENTITY_EVENT_TYPE.LOGOUT, 'onLogoutComplete');
}

public onModifyComplete(user: IMParticleUser, _filteredIdentityRequest: unknown): string {
const filteredUser = user as FilteredUser;
this.userAttributes = user.getAllUserAttributes();
this.pendingIdentityEvents.push(this.buildIdentityEvent(ROKT_IDENTITY_EVENT_TYPE.MODIFY_USER, filteredUser));
return 'Successfully called onModifyComplete for forwarder: ' + name;
return this.handleIdentityComplete(user, ROKT_IDENTITY_EVENT_TYPE.MODIFY_USER, 'onModifyComplete');
}

/**
Expand Down
Loading