Merged
Conversation
|
|
||
| public onUserIdentified(user: IMParticleUser): string { | ||
| this.filters.filteredUser = user as FilteredUser; | ||
| return this.handleIdentityComplete(user, 'identify', 'onUserIdentified'); |
Collaborator
There was a problem hiding this comment.
Nit: we should make these constants.
alexs-mparticle
approved these changes
Apr 15, 2026
rmi22186
approved these changes
Apr 15, 2026
Collaborator
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
nit: only feedback I have is the name of the commit - thought it says refactor, reduce duplication of identity events makes it sound like there was actual event duplication vs this DRY-ing things up.
refactor: DRY identity calls?
jamesnrokt
changed the title
Resolves conflict between DRY refactor (handleIdentityComplete) and the identity event schema fix (#88) by using RoktIdentityEventType enum constants in the shared helper. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
@rmi22186 renamed the PR and resolved conflicts |
rmi22186
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleIdentityCompletefor all identity eventsTesting Plan